[7.x] Use embeddable v2 (#39126)#41042
Merged
stacey-gammon merged 1 commit intoelastic:7.xfrom Jul 12, 2019
Merged
Conversation
* Final Embeddable API V2 PR * fix: import discover embeddable scss file * address code review comments * Add a functional test that would have caught the bug... will look to add a unit version once I discover the error. * Fix bug cause by async loading calls and changes to parent input while child is being created. added jest test * remove outdated readme in dashboard folder * need to always refresh dashboard container, not just when "dirty" * add a wait, this issue started appearing right when I added this to the test * Remove test that kills kibana ci so it's not a blocker. jest test was added for this scenario * fix issues when panel is added then removed before it completes loading * fix logic error with maps embeddable and isLayerTOCOpen
Contributor
💚 Build Succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backports #39126
Final Embeddable API V2 PR
fix: import discover embeddable scss file
address code review comments
Add a functional test that would have caught the bug... will look to add a unit version once I discover the error.
Fix bug cause by async loading calls and changes to parent input while child is being created. added jest test
remove outdated readme in dashboard folder
need to always refresh dashboard container, not just when "dirty"
add a wait, this issue started appearing right when I added this to the test
Remove test that kills kibana ci so it's not a blocker. jest test was added for this scenario
fix issues when panel is added then removed before it completes loading
fix logic error with maps embeddable and isLayerTOCOpen
Summary
Summarize your PR. If it involves visual changes include a screenshot or gif.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers