Skip to content

[7.x] Use embeddable v2 (#39126)#41042

Merged
stacey-gammon merged 1 commit intoelastic:7.xfrom
stacey-gammon:6-x-2019-07-12-backport-embeddables-v2
Jul 12, 2019
Merged

[7.x] Use embeddable v2 (#39126)#41042
stacey-gammon merged 1 commit intoelastic:7.xfrom
stacey-gammon:6-x-2019-07-12-backport-embeddables-v2

Conversation

@stacey-gammon
Copy link

backports #39126

  • Final Embeddable API V2 PR

  • fix: import discover embeddable scss file

  • address code review comments

  • Add a functional test that would have caught the bug... will look to add a unit version once I discover the error.

  • Fix bug cause by async loading calls and changes to parent input while child is being created. added jest test

  • remove outdated readme in dashboard folder

  • need to always refresh dashboard container, not just when "dirty"

  • add a wait, this issue started appearing right when I added this to the test

  • Remove test that kills kibana ci so it's not a blocker. jest test was added for this scenario

  • fix issues when panel is added then removed before it completes loading

  • fix logic error with maps embeddable and isLayerTOCOpen

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

* Final Embeddable API V2 PR

* fix: import discover embeddable scss file

* address code review comments

* Add a functional test that would have caught the bug... will look to add a unit version once I discover the error.

* Fix bug cause by async loading calls and changes to parent input while child is being created. added jest test

* remove outdated readme in dashboard folder

* need to always refresh dashboard container, not just when "dirty"

* add a wait, this issue started appearing right when I added this to the test

* Remove test that kills kibana ci so it's not a blocker. jest test was added for this scenario

* fix issues when panel is added then removed before it completes loading

* fix logic error with maps embeddable and isLayerTOCOpen
@stacey-gammon stacey-gammon added the backport This PR is a backport of another PR label Jul 12, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@stacey-gammon stacey-gammon merged commit 458de86 into elastic:7.x Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants