[7.x] [ML] NavMenu conversion to React (#40830)#41018
Merged
alvarezmelissa87 merged 1 commit intoelastic:7.xfrom Jul 12, 2019
Merged
[7.x] [ML] NavMenu conversion to React (#40830)#41018alvarezmelissa87 merged 1 commit intoelastic:7.xfrom
alvarezmelissa87 merged 1 commit intoelastic:7.xfrom
Conversation
* create NavigationMenu and TopNav components * create timefilter wrapper class * update timefilter type file * use new navMenu * use legacy timefilter for initial conversion * remove comments * Move navMenu tabs into separate component * ensure dataFrame tab selected style works * update test * remove top padding when topNav not visible * add refresh button functionality
Contributor
|
Pinging @elastic/ml-ui |
Contributor
💔 Build Failed |
Contributor
Author
|
retest |
Contributor
💚 Build Succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: