Fix bug in Filters aggregation and Terms aggregation with Other bucket#40698
Merged
wylieconlon merged 1 commit intoelastic:masterfrom Jul 10, 2019
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-app |
wylieconlon
commented
Jul 9, 2019
| filters: { | ||
| filters: { | ||
| '': { | ||
| 'bool': { |
Contributor
Author
There was a problem hiding this comment.
This is just reformatting
Contributor
💚 Build Succeeded |
wylieconlon
pushed a commit
that referenced
this pull request
Jul 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The bug is reproduced when you run a Filters aggregation with an empty string in the filter bar, and results in a user-visible toast saying "Can't convert undefined to object". It also threw a console error saying
malformed filter agg params, missing "input" query:The bug is that the empty string was causing the query DSL not to be generated for the default Filters aggregation. This is related to the Terms aggregation with Other bucket, which uses a Filters aggregation to calculate how many documents are not included in the top terms.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers