-
Notifications
You must be signed in to change notification settings - Fork 8.5k
Reactify Top Nav Menu (kbn_top_nav) #40262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lizozom
merged 84 commits into
elastic:master
from
lizozom:newplatform/kbn-top-nav/new-directive
Jul 21, 2019
Merged
Changes from all commits
Commits
Show all changes
84 commits
Select commit
Hold shift + click to select a range
e5f6f9c
kbn top nav in discover
d5d7e38
New top nav in dashboard and vis editor
3b97926
change kbn top nav directive
1ea5b7b
Stop using template feature of kbn top nav
8a7ba6b
Combined css
c4b84bf
Merge remote-tracking branch 'upstream/master' into newplatform/kbn-t…
2e90a18
Merge branch 'newplatform/kbn-top-nav/graph' into newplatform/kbn-top…
344b055
console top nav
3c5878b
Removed unnecessary use of kbn-top-nav in dev tools app (wrapping tabs)
d01d882
Merge branch 'newplatform/kbn-top-nav/devtools-2' into newplatform/kb…
366b03a
Changed console menu to new directive
5b0a63d
Merge remote-tracking branch 'upstream/master' into newplatform/kbn-t…
9599e15
Merge remote-tracking branch 'upstream/master' into newplatform/kbn-t…
4766510
CSS adjustments + functional implementation of top nav menu item
b23d0c3
Merge remote-tracking branch 'upstream/master' into newplatform/kbn-t…
929ed9c
Fixed DevTools top nav toggle
6adc512
Optional show-border
0f24457
timelion menu works
f6906b7
Improve filter sorting logic to be more stable
c5d3a14
Merge branch 'bug/filter-manager/sorting-logic-failure' into newplatf…
20a9922
Support showing filter bar as part of top nav
daf6f98
Use search bar in top nav in discover and maps
c580fe7
tmp revert
78ea450
Merge remote-tracking branch 'upstream/master' into newplatform/kbn-t…
b3711e6
Align search bar settings accross apps
3117fce
Reverted change in ML, removed unused css
3cfa5c7
Merge remote-tracking branch 'upstream/master' into newplatform/kbn-t…
e749bd4
Added data test subj to top nav menu items
fa5332d
Watch config by value
833d49f
Some directive magic to make sure that disabledButtons functions are …
8fee73a
Fix missing controls from new top nav in some visualizations
cc5dbff
Merge remote-tracking branch 'upstream/master' into newplatform/kbn-t…
d368c94
showAutoRefreshOnly in input controls visualization
000eeb2
Fixed inspector disabled test
efe00bf
Fix dashboard action links
97496c6
snapshots
d52e581
Fixed maps filter bar
8c06d39
Remvoed comment
afd9933
Merge remote-tracking branch 'upstream/master' into newplatform/kbn-t…
5f71b4e
Update Query Bar defaults
86dbbbc
Top nav menu item tests
e6260ea
Moved storage instantiation to angular directive
ddcdda0
SearchBar jest tests
9a68d7a
Query bar additional tests
c2bc4d3
Top nav menu tests
144d8bb
Merge remote-tracking branch 'upstream/master' into newplatform/kbn-t…
247a4f7
Pass store into top nav menu correctly
e5fb6d8
watch store by reference
1856e8f
Merge remote-tracking branch 'upstream/master' into newplatform/kbn-t…
7786fa9
Added not null assertion
bcb6674
Make index patterns optional (for timepicker only setup)
60f1643
QueryBar tests again
d7b9941
Search bar tests
362d322
Top nav tests
01b359c
Top nav menu tests
541c813
removed unnecessary ui/new_platform mock
d7fe175
Merge remote-tracking branch 'upstream/master' into newplatform/kbn-t…
caad37f
Merge remote-tracking branch 'upstream/master' into newplatform/kbn-t…
5cac8c9
Moved discover result count away from top nav
3316b4a
Moved and improved top nav menu css
4d64d66
remove unused translations
0401c7f
Merge remote-tracking branch 'upstream/master' into newplatform/kbn-t…
d5e07ab
Merge remote-tracking branch 'upstream/master' into newplatform/kbn-t…
ff59ab8
Merge remote-tracking branch 'upstream/master' into newplatform/kbn-t…
209797d
Code review part 1
37d7a98
Code review part 2 - clean up top nav menu item run interface
8729b57
Give top nav items better keys
d6f904f
Simplified top nav construction logic in editor
c6f6ca5
Merge remote-tracking branch 'upstream/master' into newplatform/kbn-t…
8881518
Merge remote-tracking branch 'upstream/master' into newplatform/kbn-t…
d127cfd
Moved filter trigger button rendering to helper function
541a779
Remove responsiveness from top nav items
a6ba593
vertical align for cases where showSearchBarInline is true
f5ea79d
Export TopNavMenuData type
045efb0
Removed unused name attribute in top nav. Use app-name instead.
3232156
Copy KEY => ID in angular directive
b848d3a
Fix top nav menu test TS
c084f14
Minor ts fix
07d0d3f
@cchaos code review fixes
f9526d7
Merge branch 'master' of github.com:elastic/kibana into newplatform/k…
1994d2c
Minor discover code review fixes
4fa6314
Merge remote-tracking branch 'upstream/master' into newplatform/kbn-t…
0c5b15a
css fix
c047384
Merge branch 'newplatform/kbn-top-nav/new-directive' of github.com:li…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
src/legacy/core_plugins/data/public/filter/filter_bar/_global_filter_group.scss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
58 changes: 49 additions & 9 deletions
58
...core_plugins/data/public/query/query_bar/components/__snapshots__/query_bar.test.tsx.snap
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.