[ts] upgrade to 3.5.3 by spalger · Pull Request #40228 · elastic/kibana

spalger · 2019-07-03T02:47:01Z

This PR upgrades us to TS 3.5.2. All issues should be resolved. The main differences between these versions include the new readonly support for array types, and slightly stricter handling of index-signatures for unknown values.

elasticmachine · 2019-07-03T02:47:03Z

Pinging @elastic/kibana-operations

src/legacy/core_plugins/embeddable_api/public/test_samples/embeddables/filterable_container.tsx

elasticmachine · 2019-07-03T03:55:11Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

timroes · 2019-07-03T11:49:14Z

Solved that EditorConfigProvider issue via #40250

x-pack/test/ui_capabilities/common/types.ts

x-pack/legacy/plugins/beats_management/server/rest_api/beats/enroll.ts

x-pack/legacy/plugins/ml/public/data_frame/pages/data_frame_new_pivot/wizard.tsx

sorenlouv · 2019-07-09T10:04:10Z

...acy/plugins/apm/public/components/app/ErrorGroupDetails/DetailView/StickyErrorProperties.tsx

        transactionId: transaction.transaction.id,
-        traceId: transaction.trace.id,
-        banana: 'ok'
+        traceId: transaction.trace.id


Wat? Thanks for fixing this... 🍌not 🆗

x-pack/legacy/plugins/apm/typings/es_schemas/raw/ErrorRaw.ts

src/legacy/core_plugins/data/public/expressions/expressions_service.test.tsx

eliperelman

Looks good.

# Conflicts: # x-pack/legacy/plugins/canvas/server/usage/custom_element_collector.ts # x-pack/legacy/plugins/canvas/server/usage/workpad_collector.ts

elasticmachine · 2019-07-10T16:29:16Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-07-10T16:54:18Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

spalger · 2019-07-10T17:01:55Z

retest

cqliu1

LGTM 👍

spalger · 2019-07-10T18:12:52Z

retest

elasticmachine · 2019-07-10T18:29:03Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-07-10T19:17:47Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

* [ts] upgrade to 3.5.2 * [ts] run from cwd so that relative paths are correct * move eslint-disable-line comment into jsx attribute * autofix eslint violations * avoid generic type, it's not necessary and problematic * make elasticsearch.cluster optional, many instances don't have them * remove invalid prop * expand AllowUnknownProperties to cleanly handle arrays * esfilter values can sometimes be an array of strings * allow exception objects to have unknown properties * define accumulator as a boolean * fix return type * return a 404 if beat isn't found after update * use Object.values for better types * define return type of get() call * define value type for Set * define return value of get() * define State property type * use less get(), so ts can infer types * define Set item type * map state type * make default_operator optional, since it's not always defined * remove seemingly unused prop * define return type of get() fn * define inner type for state * don't define base types are objects with index signatues * regenerate public api docs * make indices privileges optional too * remove unnecessary index-signature from Exception interface * use variadic _arg instead * [core/plugin] use Record<string, any> rather than {} * replace a couple more instances of {} * revert some unnecessary changes * remove unused types * [reporting] output, payload, and meta are required properties * bump to latest patch version # Conflicts: # x-pack/legacy/plugins/canvas/server/usage/custom_element_collector.ts # x-pack/legacy/plugins/canvas/server/usage/workpad_collector.ts

* [ts] upgrade to 3.5.3 (#40228) * [ts] upgrade to 3.5.2 * [ts] run from cwd so that relative paths are correct * move eslint-disable-line comment into jsx attribute * autofix eslint violations * avoid generic type, it's not necessary and problematic * make elasticsearch.cluster optional, many instances don't have them * remove invalid prop * expand AllowUnknownProperties to cleanly handle arrays * esfilter values can sometimes be an array of strings * allow exception objects to have unknown properties * define accumulator as a boolean * fix return type * return a 404 if beat isn't found after update * use Object.values for better types * define return type of get() call * define value type for Set * define return value of get() * define State property type * use less get(), so ts can infer types * define Set item type * map state type * make default_operator optional, since it's not always defined * remove seemingly unused prop * define return type of get() fn * define inner type for state * don't define base types are objects with index signatues * regenerate public api docs * make indices privileges optional too * remove unnecessary index-signature from Exception interface * use variadic _arg instead * [core/plugin] use Record<string, any> rather than {} * replace a couple more instances of {} * revert some unnecessary changes * remove unused types * [reporting] output, payload, and meta are required properties * bump to latest patch version # Conflicts: # x-pack/legacy/plugins/canvas/server/usage/custom_element_collector.ts # x-pack/legacy/plugins/canvas/server/usage/workpad_collector.ts * define inner type for Set * default `config.get()` to any instead of unknown

spalger · 2019-07-10T22:22:51Z

7.x/7.4: 1591c25

spalger added Team:Operations Kibana-Operations Team v8.0.0 v7.3.0 labels Jul 3, 2019

spalger commented Jul 3, 2019

View reviewed changes

src/legacy/core_plugins/embeddable_api/public/test_samples/embeddables/filterable_container.tsx Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

spalger force-pushed the upgrade/ts branch from 373496d to ef746f4 Compare July 3, 2019 04:25

spalger added the v7.4.0 label Jul 3, 2019

spalger force-pushed the upgrade/ts branch 2 times, most recently from f4ff49d to 9c75ee6 Compare July 5, 2019 14:35

spalger commented Jul 5, 2019

View reviewed changes

x-pack/test/ui_capabilities/common/types.ts Outdated Show resolved Hide resolved

spalger commented Jul 5, 2019

View reviewed changes

x-pack/legacy/plugins/beats_management/server/rest_api/beats/enroll.ts Outdated Show resolved Hide resolved

spalger commented Jul 5, 2019

View reviewed changes

x-pack/legacy/plugins/ml/public/data_frame/pages/data_frame_new_pivot/wizard.tsx Outdated Show resolved Hide resolved

spalger added 15 commits July 5, 2019 09:56

[ts] upgrade to 3.5.2

dcbeb97

[ts] run from cwd so that relative paths are correct

0a7682b

move eslint-disable-line comment into jsx attribute

fad55da

autofix eslint violations

aba950d

avoid generic type, it's not necessary and problematic

f3ff57b

make elasticsearch.cluster optional, many instances don't have them

4e2aa4d

remove invalid prop

d02910d

expand AllowUnknownProperties to cleanly handle arrays

eb98ecc

esfilter values can sometimes be an array of strings

f9e9ca2

allow exception objects to have unknown properties

6967596

define accumulator as a boolean

cdeec51

fix return type

afff41c

return a 404 if beat isn't found after update

a7314f4

use Object.values for better types

fdaa18e

define return type of get() call

99ea498

sorenlouv reviewed Jul 9, 2019

View reviewed changes

x-pack/legacy/plugins/apm/typings/es_schemas/raw/ErrorRaw.ts Outdated Show resolved Hide resolved

sorenlouv approved these changes Jul 9, 2019

View reviewed changes

eliperelman reviewed Jul 9, 2019

View reviewed changes

src/legacy/core_plugins/data/public/expressions/expressions_service.test.tsx Outdated Show resolved Hide resolved

eliperelman approved these changes Jul 9, 2019

View reviewed changes

jbudz approved these changes Jul 9, 2019

View reviewed changes

spalger added 9 commits July 10, 2019 08:03

remove unnecessary index-signature from Exception interface

9c1cc30

use variadic _arg instead

6f5643e

Merge branch 'master' of github.com:elastic/kibana into upgrade/ts

20e33d5

# Conflicts: # x-pack/legacy/plugins/canvas/server/usage/custom_element_collector.ts # x-pack/legacy/plugins/canvas/server/usage/workpad_collector.ts

[core/plugin] use Record<string, any> rather than {}

d306d79

replace a couple more instances of {}

693bac7

revert some unnecessary changes

27b7573

remove unused types

9eececa

[reporting] output, payload, and meta are required properties

3efc376

bump to latest patch version

03c3588

spalger changed the title ~~[ts] upgrade to 3.5.2~~ [ts] upgrade to 3.5.3 Jul 10, 2019

cqliu1 approved these changes Jul 10, 2019

View reviewed changes

spalger merged commit 415e3bc into elastic:master Jul 10, 2019

spalger mentioned this pull request Jul 10, 2019

[7.x] [ts] upgrade to 3.5.3 (#40228) #40795

Merged

spalger deleted the upgrade/ts branch July 10, 2019 22:22

mshustov mentioned this pull request Jul 11, 2019

Narrow type of PluginDeps to an object #40846

Merged

Conversation

spalger commented Jul 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticmachine commented Jul 3, 2019

Uh oh!

Uh oh!

This comment has been minimized.

elasticmachine commented Jul 3, 2019

💔 Build Failed

Uh oh!

timroes commented Jul 3, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sorenlouv Jul 9, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jasonrhodes Jul 9, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

eliperelman left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Jul 10, 2019

💚 Build Succeeded

Uh oh!

elasticmachine commented Jul 10, 2019

💔 Build Failed

Uh oh!

spalger commented Jul 10, 2019

Uh oh!

cqliu1 left a comment

Choose a reason for hiding this comment

Uh oh!

spalger commented Jul 10, 2019

Uh oh!

elasticmachine commented Jul 10, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Jul 10, 2019

💚 Build Succeeded

Uh oh!

spalger commented Jul 10, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

16 participants

spalger commented Jul 3, 2019 •

edited

Loading

sorenlouv Jul 9, 2019 •

edited

Loading