Move path/patterns to common/routes. Export get*Path functions for correct value

[jfsiii]

Summary

TL;DR: the client-side data fetching functions changed.

 export async function getIntegrationsList(): Promise<IntegrationList> {
-  const path = API_INTEGRATIONS_LIST;
+  const path = getListPath();
   const list: IntegrationList = await _fetch(path); 
 
   return list;
 }
 
 export async function getIntegrationInfoByKey(pkgkey: string): Promise<IntegrationInfo> {
-  const path = API_INTEGRATIONS_INFO.replace('{pkgkey}', pkgkey);
+  const path = getInfoPath(pkgkey);
   const info: IntegrationInfo = await _fetch(path);
 
   return info;

Problem

The client needs to know the location of certain routes (e.g. package list & detail APIs). The server clearly needs to know about these to create the handlers. How can we define route names & paths in one location without making the client & server worlds collide?

Proposal

Store the path/pattern that the server router uses from in common/routes.

The server imports the paths from common/routes and defines its route handlers in server/routes.

The client calls get*Path, with any parameters to substitute, and that function returns the correct path.

[jfsiii]

I should note this is “works for the 3 cases we have now”-level code. We’ll come back to this and change the shape as required.

[jasonrhodes]

Looks good, just a few changes/comments to work through. My overall reaction is this may be a bit more than what we need right now to get something simple off the ground, but I see the advantages too.

[jfsiii]

@jasonrhodes mind taking another look? I made it much closer to what we’re currently doing, but still moved knowledge/work out of the views.

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request

[jasonrhodes]

Looks great, thanks for simplifying. 👍