[ML] [Accessibility] "Select this row" checkbox reads description#39821
Closed
PhilippBaranovskiy wants to merge 1 commit intoelastic:masterfrom
Closed
[ML] [Accessibility] "Select this row" checkbox reads description#39821PhilippBaranovskiy wants to merge 1 commit intoelastic:masterfrom
PhilippBaranovskiy wants to merge 1 commit intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/ml-ui |
Contributor
Author
|
Updated:
|
Contributor
|
Closing in favour of #40149 which uses the job ID rather than the description (which may be blank, and not unique). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #28390
On hold
This PR is fully packed and waits until EUI version newer than 12.1.0 is being merged into Kibana.
Once 12.1.1+ version is merged, the associated issue #28390 is ready to be marked fixed.
This PR is ready to be merged already now.
Summary
It uses
selectableMessagemethod to construct a propertitleandaria-labelattributes.Further details can be found in that PR: elastic/eui#2043
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Documentation was added for features that require explanation or tutorials[ ] Unit or functional tests were updated or added to match the most common scenariosFor maintainers