Added snapshot restore smoke test to ensure the app has loaded. by cuff-links · Pull Request #39812 · elastic/kibana

cuff-links · 2019-06-27T17:00:51Z

Fixes #39286

elasticmachine · 2019-06-27T17:12:19Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

spalger · 2019-06-27T19:56:36Z

eslint issues fixed in master

cuff-links · 2019-06-27T20:18:45Z

retest

…sitories_App_Load_Test

elasticmachine · 2019-06-27T21:01:19Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

cuff-links · 2019-06-28T06:26:43Z

retest

cuff-links · 2019-06-28T06:43:31Z

Failure had nothing to do with this test.

elasticmachine · 2019-06-28T07:22:02Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-07-01T18:12:10Z

Pinging @elastic/es-ui

jen-huang

Code LGTM! This PR just needs to be updated with latest master, and there may be a few things that need to be changed after updating (see comments).

jen-huang · 2019-07-01T18:13:47Z

x-pack/test/functional/apps/snapshot_restore/home_page.ts

+    });
+
+    it('Loads the app', async () => {
+      const appTitle = 'Snapshot Repositories';


#39193 was merged, so when this PR is updated with latest master, this should be changed to Snapshot and Restore

jen-huang · 2019-07-01T18:16:10Z

x-pack/test/functional/apps/snapshot_restore/home_page.ts

+      const appTitleText = await pageObjects.snapshotRestore.appTitleText();
+      expect(appTitleText).to.be(appTitle);
+
+      const repositoriesButton = await pageObjects.snapshotRestore.registerRepositoryButton();


(similar to previous) #39193 was merged, which changed the default tab to Snapshots instead of Repositories. I think this assertion is still valid, because we show the register repository button on empty snapshot list as well, but might want to double check

Yes. This assertion still works. Thanks for the thorough eye.

jen-huang · 2019-07-01T18:19:31Z

@elastic/es-ui I changed the release note flagging on this PR to release_note:skip instead of release_note:enhancement. I think PRs which just add tests don't need to be talked about in the release notes, let me know if you feel otherwise.

…sitories_App_Load_Test

elasticmachine · 2019-07-02T21:23:29Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

cjcenizal · 2019-07-03T02:32:22Z

Retest

elasticmachine · 2019-07-03T03:30:35Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

…sitories_App_Load_Test

elasticmachine · 2019-07-06T04:22:41Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

…sitories_App_Load_Test

…e30/kibana into Snapshot_Repositories_App_Load_Test

elasticmachine · 2019-07-06T07:09:14Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

…tic#39812) * Added snapshot restore smoke test to ensure the app has loaded. * Fixed linting issues. * Updated test to reflect changes to Snapshot and Restore's name. * Fixed merge update.

…) (#40459) * Added snapshot restore smoke test to ensure the app has loaded. * Fixed linting issues. * Updated test to reflect changes to Snapshot and Restore's name. * Fixed merge update.

…tic#39812) * Added snapshot restore smoke test to ensure the app has loaded. * Fixed linting issues. * Updated test to reflect changes to Snapshot and Restore's name. * Fixed merge update.

…d. (elastic#39812)" This reverts commit 95c6158.

* Revert "Fixed import from a different PR." This reverts commit 4ecbddc. * Revert "Added snapshot restore smoke test to ensure the app has loaded. (#39812)" This reverts commit 95c6158.

…tic#39812) * Added snapshot restore smoke test to ensure the app has loaded. * Fixed linting issues. * Updated test to reflect changes to Snapshot and Restore's name. * Fixed merge update.

…) (#40561) * Added snapshot restore smoke test to ensure the app has loaded. * Fixed linting issues. * Updated test to reflect changes to Snapshot and Restore's name. * Fixed merge update.

Added snapshot restore smoke test to ensure the app has loaded.

b4077ec

cuff-links requested a review from jen-huang June 27, 2019 17:00

cuff-links added the release_note:enhancement label Jun 27, 2019

Fixed linting issues.

b5eea77

Merge branch 'master' of github.com:elastic/kibana into Snapshot_Repo…

f7bf0eb

…sitories_App_Load_Test

jen-huang added Feature:Snapshot and Restore Elasticsearch snapshots and repositories UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// v7.3.0 v8.0.0 labels Jul 1, 2019

jen-huang approved these changes Jul 1, 2019

View reviewed changes

jen-huang added release_note:skip Skip the PR/issue when compiling release notes and removed release_note:enhancement labels Jul 1, 2019

jen-huang mentioned this pull request Jul 1, 2019

[SR] Snapshot and Restore UI #39193

Merged

John Dorlus added 2 commits July 2, 2019 16:54

Merge branch 'master' of github.com:elastic/kibana into Snapshot_Repo…

1eea52b

…sitories_App_Load_Test

Updated test to reflect changes to Snapshot and Restore's name.

aaf0314

cjcenizal added v7.4.0 and removed v7.3.0 labels Jul 3, 2019

Merge branch 'master' of github.com:elastic/kibana into Snapshot_Repo…

587f1b7

…sitories_App_Load_Test

John Dorlus added 3 commits July 6, 2019 01:30

Merge branch 'master' of github.com:elastic/kibana into Snapshot_Repo…

bca7dc3

…sitories_App_Load_Test

Merge branch 'Snapshot_Repositories_App_Load_Test' of github.com:siln…

b7ea1fa

…e30/kibana into Snapshot_Repositories_App_Load_Test

Fixed merge update.

4671609

cuff-links merged commit a965a06 into elastic:master Jul 6, 2019

cuff-links mentioned this pull request Jul 6, 2019

[7.x] Added snapshot restore smoke test to ensure the app has loaded. (#39812) #40459

Merged

cuff-links mentioned this pull request Jul 7, 2019

[7.3] Added snapshot restore smoke test to ensure the app has loaded. (#39812) #40476

Merged

cuff-links pushed a commit to cuff-links/kibana that referenced this pull request Jul 8, 2019

Revert "Added snapshot restore smoke test to ensure the app has loade…

b2c20b5

…d. (elastic#39812)" This reverts commit 95c6158.

cuff-links mentioned this pull request Jul 9, 2019

[7.3] Added snapshot restore smoke test to ensure the app has loaded. (#39812) #40561

Merged

Conversation

cuff-links commented Jun 27, 2019

Uh oh!

elasticmachine commented Jun 27, 2019

💔 Build Failed

Uh oh!

spalger commented Jun 27, 2019

Uh oh!

cuff-links commented Jun 27, 2019

Uh oh!

elasticmachine commented Jun 27, 2019

💔 Build Failed

Uh oh!

cuff-links commented Jun 28, 2019

Uh oh!

cuff-links commented Jun 28, 2019

Uh oh!

elasticmachine commented Jun 28, 2019

💚 Build Succeeded

Uh oh!

elasticmachine commented Jul 1, 2019

Uh oh!

jen-huang left a comment

Choose a reason for hiding this comment

Uh oh!

jen-huang Jul 1, 2019

Choose a reason for hiding this comment

Uh oh!

jen-huang Jul 1, 2019

Choose a reason for hiding this comment

Uh oh!

cuff-links Jul 2, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jen-huang commented Jul 1, 2019

Uh oh!

elasticmachine commented Jul 2, 2019

💔 Build Failed

Uh oh!

cjcenizal commented Jul 3, 2019

Uh oh!

elasticmachine commented Jul 3, 2019

💚 Build Succeeded

Uh oh!

elasticmachine commented Jul 6, 2019

💚 Build Succeeded

Uh oh!

elasticmachine commented Jul 6, 2019

💚 Build Succeeded

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

cuff-links Jul 2, 2019 •

edited

Loading