[Maps] add multiple feature selection in tooltips by thomasneirynck · Pull Request #39629 · elastic/kibana

thomasneirynck · 2019-06-25T22:16:42Z

WIP, do not merge

2nd DRAFT

added @ryankeairns suggestions:

hovering, single feature

hovering, multi features

locked, single layer / single feature

locked, single layer / multi features

locked, multi-layers / multi-features

locked, multi-layers / single feature (after layer-filter)

1st DRAFT

Adds carrousel and layer-selector to cycle through the results under the mouse pointer

Closes #29005

elasticmachine · 2019-06-25T22:17:05Z

Pinging @elastic/kibana-gis

elasticmachine · 2019-06-25T23:33:43Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-06-26T22:10:31Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

nreese · 2019-06-27T12:57:27Z

FeatureTooltip is getting rather large. Want to break it into smaller components? Maybe put FeatureProperties into its own component? That way, FeatureTooltip would just pass featureId, layerId, and loadFeatureProperties to FeatureProperties and FeatureProperties could encapsulate loading feature props and rendering table

nreese · 2019-06-27T13:15:15Z

The feature selection controls dominate the tooltip. How about putting them in a panel with a grey background color or adding a horizontal rule so they are visually separated from the property content a little more?

ryankeairns · 2019-06-27T14:38:33Z

Thomas and I talked and came up with revised layouts for the case where there is only one layer and where there are many layers or many data points.

The layer selector and compressed pagination (arrows; no page numbers) will only appear when the data dictates a need for it. These controls allow users to select a specific layer (reduce the volume of data) and/or quickly flip through the data points.

The iInCircle would display an EuiToolTip explaining that filtering can be used to as another way to reduce the amount of data being presented.

elasticmachine · 2019-06-27T16:33:23Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-06-27T17:10:59Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-06-28T15:17:15Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

…oltip

ryankeairns

👍 LGTM. Tried it out locally, added layers, works as described/designed.

elasticmachine · 2019-06-28T16:37:56Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

thomasneirynck · 2019-06-28T16:57:41Z

retest

elasticmachine · 2019-06-28T18:05:04Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

thomasneirynck · 2019-06-28T19:31:11Z

retest

elasticmachine · 2019-06-28T20:40:06Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

… into maps/multi_tooltip

elasticmachine · 2019-06-28T22:19:08Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

…oltip

… into maps/multi_tooltip

elasticmachine · 2019-07-01T15:09:08Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

nreese

lgtm
code review and tested in chrome

elasticmachine · 2019-07-01T16:19:08Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

add pagination

63f937e

thomasneirynck added Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v7.3.0 v8.0.0 WIP Work in progress labels Jun 25, 2019

Merge remote-tracking branch 'upstream/master' into maps/multi_tooltip

b579102

thomasneirynck requested a review from ryankeairns June 26, 2019 15:22

thomasneirynck added 4 commits June 26, 2019 16:12

add layer filtering

d1f67f7

change ordering

c7d0900

reset layer selection on change

72f0aac

show count

ea4bcc7

thomasneirynck added the release_note:enhancement label Jun 26, 2019

thomasneirynck requested review from kindsun and nreese June 26, 2019 21:13

thomasneirynck added 2 commits June 27, 2019 11:20

factor out feature properties

94c0e58

rearrange inputs

c9c8d5f

small changes

d4b935b

thomasneirynck added 5 commits June 27, 2019 13:48

change condition

2e5eb1c

toggle hint

7ae18c0

use html the right way

73add06

fix on close tooltip

54c9f2d

typo

b5d3746

Merge branch 'master' of github.com:elastic/kibana into maps/multi_to…

7b41e44

…oltip

ryankeairns approved these changes Jun 28, 2019

View reviewed changes

thomasneirynck removed the WIP Work in progress label Jun 28, 2019

nreese reviewed Jun 28, 2019

View reviewed changes

thomasneirynck added 2 commits June 28, 2019 16:55

lint

fd57484

Merge branch 'maps/multi_tooltip' of github.com:thomasneirynck/kibana…

5ce4343

… into maps/multi_tooltip

thomasneirynck added 5 commits July 1, 2019 09:39

feedback

cdb7e50

update snapshot

89af06d

Merge branch 'master' of github.com:elastic/kibana into maps/multi_to…

5f37d62

…oltip

use map

42e61d3

Merge branch 'maps/multi_tooltip' of github.com:thomasneirynck/kibana…

6ad3108

… into maps/multi_tooltip

thomasneirynck requested a review from nreese July 1, 2019 14:09

nreese reviewed Jul 1, 2019

View reviewed changes

Comment thread x-pack/legacy/plugins/maps/public/components/map/feature_tooltip.js Outdated

sloppy sloppy tsk tsk

17697d2

thomasneirynck requested a review from nreese July 1, 2019 15:21

nreese approved these changes Jul 1, 2019

View reviewed changes

thomasneirynck merged commit e1b1c56 into elastic:master Jul 1, 2019

thomasneirynck mentioned this pull request Jul 1, 2019

[7.x] [Maps] add multiple feature selection in tooltips (#39629) #40052

Merged

thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request Jul 1, 2019

[Maps] add multiple feature selection in tooltips (elastic#39629)

5c6a2d8

thomasneirynck added a commit that referenced this pull request Jul 1, 2019

[Maps] add multiple feature selection in tooltips (#39629) (#40052)

c66eefb

thomasneirynck mentioned this pull request Jul 8, 2019

[Maps] Tooltip doesn't resize to fit larger content #40514

Closed

Conversation

thomasneirynck commented Jun 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticmachine commented Jun 25, 2019

Uh oh!

elasticmachine commented Jun 25, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Jun 26, 2019

💔 Build Failed

Uh oh!

nreese commented Jun 27, 2019

Uh oh!

nreese commented Jun 27, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ryankeairns commented Jun 27, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticmachine commented Jun 27, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Jun 27, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Jun 28, 2019

💔 Build Failed

Uh oh!

ryankeairns left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Jun 28, 2019

💔 Build Failed

Uh oh!

thomasneirynck commented Jun 28, 2019

Uh oh!

elasticmachine commented Jun 28, 2019

💔 Build Failed

Uh oh!

thomasneirynck commented Jun 28, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

elasticmachine commented Jun 28, 2019

💚 Build Succeeded

Uh oh!

elasticmachine commented Jun 28, 2019

💚 Build Succeeded

Uh oh!

Uh oh!

elasticmachine commented Jul 1, 2019

💚 Build Succeeded

Uh oh!

nreese left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Jul 1, 2019

💚 Build Succeeded

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

thomasneirynck commented Jun 25, 2019 •

edited

Loading

nreese commented Jun 27, 2019 •

edited

Loading

ryankeairns commented Jun 27, 2019 •

edited

Loading