-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[Lens] Popover configs #39565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
flash1293
merged 49 commits into
elastic:feature/lens
from
flash1293:lens/popover-configs
Jun 27, 2019
Merged
[Lens] Popover configs #39565
Changes from all commits
Commits
Show all changes
49 commits
Select commit
Hold shift + click to select a range
f46855e
[lens] Dimension panel lets users select operations and fields indivi…
wylieconlon dcde41d
Merge remote-tracking branch 'origin/feature/lens' into lens/aggregat…
wylieconlon 4a3ea3f
Merge remote-tracking branch 'origin/master' into lens/aggregations
wylieconlon 30f69e3
Split files and add tests
wylieconlon 82e2865
Merge remote-tracking branch 'origin/feature/lens' into lens/aggregat…
wylieconlon fe4238a
Fix dimension labeling and add clear button
wylieconlon 4d09416
Support more aggregations, aggregation nesting, rollups, and clearing
wylieconlon 6f81ded
Merge remote-tracking branch 'origin/feature/lens' into lens/aggregat…
wylieconlon 3bf54d4
Fix esaggs expression
wylieconlon 241187b
Merge remote-tracking branch 'origin/feature/lens' into lens/aggregat…
wylieconlon 8c50598
Increase top-level test coverage of dimension panel
wylieconlon 063715c
Merge branch 'feature/lens' into lens/aggregations
flash1293 8359b28
start work on param editors for operations
flash1293 6a3e6f8
add params for terms
flash1293 9cb80a8
remove unused variable
flash1293 4718369
Merge branch 'feature/lens' into lens/agg-configs
flash1293 5510db0
refactor operations
flash1293 404944f
move esaggs configurations to individual operation files
flash1293 8e0dc86
implement new edit flow
flash1293 520f0e7
split up dimension panel code
flash1293 7d6f3c9
Merge branch 'feature/lens' into lens/agg-configs
flash1293 cdcc822
fix some tests
flash1293 3e7c3b4
Merge branch 'feature/lens' into lens/agg-configs
flash1293 b72998d
moved stuff around and started cleaning up and adding tests
flash1293 41eb4d4
fix tests for dimension panel
flash1293 0674c2c
fix tests
flash1293 6d420e6
add tests and i18n
flash1293 2f54558
added a few more tests
flash1293 d3e356c
add test subj
flash1293 a1f55cf
remove unused import
flash1293 60c0239
start work on operation switching
flash1293 4511c81
highlight currently active operation
flash1293 5183115
Merge branch 'feature/lens' into lens/popover-configs
flash1293 6d91f2e
Auto format
flash1293 2cdc322
adjust user flow as discussed
flash1293 aa3c8fd
Merge branch 'feature/lens' into lens/popover-configs
flash1293 1ae848f
resolve merge conflicts
flash1293 09328ad
fix styling and add label behavior
flash1293 82b7ce4
start fixing tests and things
flash1293 df18560
fix css issues
flash1293 78f45c5
fix existing dimension panel test
flash1293 f82a200
add tests
flash1293 2798552
condense tests
flash1293 486bae9
rename stuff and carry over params when switching columns if possible
flash1293 46f594a
Merge branch 'feature/lens' into lens/popover-configs
flash1293 2690790
PR review fixes
flash1293 bbf573b
Merge branch 'feature/lens' into lens/popover-configs
flash1293 c4947bc
review fixes
flash1293 084cd26
Merge branch 'feature/lens' into lens/popover-configs
flash1293 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| // Import the EUI global scope so we can use EUI constants | ||
| @import 'src/legacy/ui/public/styles/_styling_constants'; | ||
|
|
||
| @import './drag_drop/drag_drop.scss'; | ||
| @import './xy_visualization_plugin/xy_expression.scss'; | ||
| @import './indexpattern_plugin/indexpattern'; | ||
| @import './editor_frame_plugin/editor_frame/index'; | ||
| @import './drag_drop/drag_drop.scss'; | ||
| @import './editor_frame_plugin/editor_frame/index'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
x-pack/legacy/plugins/lens/public/indexpattern_plugin/dimension_panel/_index.scss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| @import './popover'; | ||
| @import './summary'; |
30 changes: 30 additions & 0 deletions
30
x-pack/legacy/plugins/lens/public/indexpattern_plugin/dimension_panel/_popover.scss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| .lnsConfigPanel__summaryPopoverLeft, | ||
| .lnsConfigPanel__summaryPopoverRight { | ||
| padding: $euiSizeS; | ||
| } | ||
|
|
||
| .lnsConfigPanel__summaryPopoverLeft { | ||
| padding-top: 0; | ||
| background-color: $euiColorLightestShade; | ||
| } | ||
|
|
||
| .lnsConfigPanel__summaryPopoverRight { | ||
| width: $euiSize * 20; | ||
| } | ||
|
|
||
| .lnsConfigPanel__fieldOption--incompatible { | ||
| color: $euiColorLightShade; | ||
| } | ||
|
|
||
| .lnsConfigPanel__operation { | ||
| padding: $euiSizeXS; | ||
| font-size: 0.875rem; | ||
| } | ||
|
|
||
| .lnsConfigPanel__operation--selected { | ||
| background-color: $euiColorLightShade; | ||
| } | ||
|
|
||
| .lnsConfigPanel__operation--incompatible { | ||
| opacity: 0.7; | ||
| } | ||
32 changes: 32 additions & 0 deletions
32
x-pack/legacy/plugins/lens/public/indexpattern_plugin/dimension_panel/_summary.scss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| .lnsConfigPanel__summary { | ||
| @include euiFontSizeS; | ||
| background: $euiColorEmptyShade; | ||
| border-radius: $euiBorderRadius; | ||
| display: flex; | ||
| align-items: center; | ||
| margin-top: $euiSizeXS; | ||
| padding: $euiSizeS; | ||
| } | ||
|
|
||
| .lnsConfigPanel__summaryPopover { | ||
| flex-grow: 1; | ||
| line-height: 0; | ||
| overflow: hidden; | ||
| } | ||
|
|
||
| .lnsConfigPanel__summaryPopoverAnchor { | ||
| max-width: 100%; | ||
| } | ||
|
|
||
| .lnsConfigPanel__summaryIcon { | ||
| margin-right: $euiSizeXS; | ||
| } | ||
|
|
||
| .lnsConfigPanel__summaryLink { | ||
| max-width: 100%; | ||
| display: flex; | ||
| } | ||
|
|
||
| .lnsConfigPanel__summaryField { | ||
| color: $euiColorPrimary; | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The lack of contrast here makes this a lot less effective than I was expecting. I think @cchaos might be able to make some suggestions, but I'm thinking that instead of opacity you could use a black font color for compatible, and gray font color for incompatible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, also not really happy with that. Maybe a separator of some kind would be a good idea?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not block the change on this