[Maps] Quick design fixes for 7.3 #39429
Merged
nreese merged 9 commits intoelastic:masterfrom Jun 27, 2019
Merged
Conversation
cchaos
added
Team:Geo
Contributor
|
Pinging @elastic/kibana-gis |
cchaos
commented
Jun 21, 2019
x-pack/legacy/plugins/file_upload/public/components/json_index_file_picker.js
Outdated
Show resolved
Hide resolved
Contributor
💚 Build Succeeded |
nreese
approved these changes
Jun 21, 2019
Contributor
nreese
left a comment
nreese
left a comment
There was a problem hiding this comment.
lgtm
code review, tested in chrome
Contributor
Author
|
I had forgotten one more that I wanted to fix: 8. Change discard changes modal to a
|
Contributor
💔 Build Failed |
kindsun
reviewed
Jun 21, 2019
x-pack/legacy/plugins/file_upload/public/components/index_settings.js
Outdated
Show resolved
Hide resolved
Contributor
💔 Build Failed |
Contributor
|
I'm currently getting this error in the console on dragging & dropping a file. Looks like just a bad style selector?
|
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
|
retest |
Contributor
💚 Build Succeeded |
kindsun
approved these changes
Jun 27, 2019
Contributor
kindsun
left a comment
kindsun
left a comment
There was a problem hiding this comment.
lgtm w/ green CI!
- Code review
- Run locally on Chrome
Contributor
Contributor
💔 Build Failed |
Contributor
|
retest |
Contributor
💚 Build Succeeded |
nreese
pushed a commit
to nreese/kibana
that referenced
this pull request
Jun 27, 2019
* Some fixes to the main listing screen * Updates to file upload layouts * Better discard changes modal * Revert prettier auto-fixes in “Updates to file upload layouts" * Revert prettier auto-fixes from "Some fixes to the main listing screen" * Missed a line * fix margin-bottom console warning * clean up un-needed fileRef
Contributor
|
7.x #39860 |
nreese
added a commit
that referenced
this pull request
Jun 28, 2019
* Some fixes to the main listing screen * Updates to file upload layouts * Better discard changes modal * Revert prettier auto-fixes in “Updates to file upload layouts" * Revert prettier auto-fixes from "Some fixes to the main listing screen" * Missed a line * fix margin-bottom console warning * clean up un-needed fileRef
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This looks like a long list, but just because I was trying to be thorough documenting what I changed, but really it was mostly spacing and component misuse edits.
Also, please excuse a lot of the diff's because my linter/prettier auto-fixed a lot of the formatting.
Listing page changes
1. Fixed the title alignment
2. Altered the help dropdown link to GH
File upload layout changes
3. File chooser screen: Moved file guidelines to help text
4. File chooser screen: Moved index pattern guidelines to below input and removed some extra spacing
5. Indexing status screen: Indexing
6. Indexing status screen: Complete
Don't use
EuiFormRowif you're not using form controls. Just use titles to add headings.I also added the
language="json"prop to the code blocks for code coloring. You may want to consider addingisCopyablein case users just want to copy and paste the whole block somewhere else.7. Added
position: relativeto the panel housing the file upload forms...so that the progress indicator is at the top of the panel not the flyout:
Before
After
Improvements I couldn't make on my own
a. When the file is first selected and is being parsed, it locks up the entire UI.
You can only see a sliver of the progress indicator as seen in the screenshot above. Consider finding a way to optimize so that the UI can still perform as the parsing is being done in the background.
b. When the indexing status is complete, add the words "Complete"
c. BUG (or feels like one): When trying to edit the pre-fab index pattern name
Anytime you try to type in the middle of the index pattern name it pushes you to the end of the string. Since you're creating this string for them, but not accounting for the specific patterns of lowercase, it makes editing only portions of the pre-fab name very frustrating.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately[ ] This includes a feature addition or change that requires a release note and was labeled appropriately