[7.x] Spaces - New Platform Migration, Step 1 (#35429)#39270
Merged
legrego merged 1 commit intoelastic:7.xfrom Jun 19, 2019
Merged
[7.x] Spaces - New Platform Migration, Step 1 (#35429)#39270legrego merged 1 commit intoelastic:7.xfrom
legrego merged 1 commit intoelastic:7.xfrom
Conversation
* crude test updates * remove custom server typedef * allow spaces to aquire security plugin after init * split CoreSetup into CoreSetup and PluginsSetup * move interfaces to new plugin * init interceptors in legacy plugin * fix import * add placeholder kibana.json * use NP Elasticsearch service instead of legacy ES Plugin * cleanup imports * don't destructure the es client * introduce request facade * document reason for getSecurity * prefer relative imports from src/core * fix typo in filename: inteceptors --> interceptors * fix imports; remove stray ts-ignore * improve typings for spaces client * rename InterfaceExcept --> Omit * don't use legacy config in NP * additional comment * shim NP config service * fix merge from master * revert relative imports into src/core and src/legacy * shim capabilities modifier into new platform * removing placeholder kibana.json * fix prettier problem * temporary: patch NP 'setUrl' * migrate onRequest interceptor to NP, without tests * fix ts error * testing and deps cleanup for onRequestInterceptor * replace spaces's usages of request.getBasePath with http.getBasePathFor * add explicit timeouts for jest interceptor tests * attempt to fix imports * use NP logging instead of faked implementation * revert stray yarn.lock change * attempt to stablize and fix tests * update jest config to include src/core/server/mocks * fix plugin config typings * add service tests * fix merge * allow spaces service to also work with legacy requests * update interfaces to confirm to new internal/external API convention * re-enable some post auth interceptor tests * add explicit timeouts for tests * prefer modifyUrl instead of manual url modification * update logger shim to conform to PluginInitializerContext * remove spaces ConfigClass * don't weaken type declaration for scoped cluster client calls * remove legacy server from SpacesCoreSetup * remove spaces service cache * remove legacy server as an interceptor dependency * use modifyUrl on the raw request too * remove unused import * cleanup typings * replace onRequest interceptor with new onPreAuth interceptor * fix onPostAuth tests * temporarily copy modifyUrl into spaces plugin * fix mock export * fix merge from master * spaces scopedClient always uses updated ES client and config * improve typings for usage collector * rename isLegacyRequest -> isFakeRequest * use updated NP base path API * remove commented code * only expose scoped spaces client * use OptionalPlugin instead of getSecurity * update imports of Saved Objects Service to use new src/core/server location * update core docs
Contributor
💔 Build Failed |
Member
Author
|
retest |
Contributor
💚 Build Succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: