Skip to content

Rename Visual Builder to TSVB#39125

Merged
timroes merged 2 commits intoelastic:masterfrom
timroes:tsvb-rename
Jun 18, 2019
Merged

Rename Visual Builder to TSVB#39125
timroes merged 2 commits intoelastic:masterfrom
timroes:tsvb-rename

Conversation

@timroes
Copy link
Contributor

@timroes timroes commented Jun 17, 2019

Summary

Renames Visual Builder to TSVB which it was already known as and referenced as for a long time.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@timroes timroes added release_note:enhancement Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v8.0.0 v7.3.0 labels Jun 17, 2019
@timroes timroes requested review from a team and markov00 June 17, 2019 20:26
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@elasticmachine
Copy link
Contributor

💔 Build Failed

Copy link
Contributor

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈 Change the sorting of the tested chart type and we are ok to merge

'Tag Cloud',
'Timelion',
'Timeseries',
'TSVB',
Copy link
Contributor

@markov00 markov00 Jun 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorting, Tim, sorting..... I told you 100 times 🤣 TSVB before Tag Cloud.
❤️ A, B, C, AA, AB, AC, Aa, Ab, Ac, a, b, c

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still learning the alphabet sorry :-( Do you have any good learning resources on that?

Copy link
Contributor

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@timroes timroes merged commit b550bfd into elastic:master Jun 18, 2019
@timroes timroes deleted the tsvb-rename branch June 18, 2019 11:30
timroes added a commit to timroes/kibana that referenced this pull request Jun 18, 2019
* Rename Visual Builder to TSVB

* A, B, C, D, E, F, G ...
timroes added a commit to timroes/kibana that referenced this pull request Jun 20, 2019
* Rename Visual Builder to TSVB

* A, B, C, D, E, F, G ...
timroes pushed a commit that referenced this pull request Jun 24, 2019
* Rename Visual Builder to TSVB

* A, B, C, D, E, F, G ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:TSVB TSVB (Time Series Visual Builder) release_note:enhancement Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.3.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants