Rename Visual Builder to TSVB#39125
Merged
timroes merged 2 commits intoelastic:masterfrom Jun 18, 2019
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-app |
Contributor
💔 Build Failed |
maryia-lapata
approved these changes
Jun 18, 2019
markov00
requested changes
Jun 18, 2019
Contributor
markov00
left a comment
There was a problem hiding this comment.
🙈 Change the sorting of the tested chart type and we are ok to merge
| 'Tag Cloud', | ||
| 'Timelion', | ||
| 'Timeseries', | ||
| 'TSVB', |
Contributor
There was a problem hiding this comment.
Sorting, Tim, sorting..... I told you 100 times 🤣 TSVB before Tag Cloud.
❤️ A, B, C, AA, AB, AC, Aa, Ab, Ac, a, b, c
Contributor
Author
There was a problem hiding this comment.
Still learning the alphabet sorry :-( Do you have any good learning resources on that?
Contributor
💚 Build Succeeded |
timroes
added a commit
to timroes/kibana
that referenced
this pull request
Jun 18, 2019
* Rename Visual Builder to TSVB * A, B, C, D, E, F, G ...
timroes
added a commit
to timroes/kibana
that referenced
this pull request
Jun 20, 2019
* Rename Visual Builder to TSVB * A, B, C, D, E, F, G ...
timroes
pushed a commit
that referenced
this pull request
Jun 24, 2019
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames Visual Builder to TSVB which it was already known as and referenced as for a long time.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Documentation was added for features that require explanation or tutorials[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately