Skip to content

Feature Controls - Simplify Saved Objects Management UI Capabilities#38461

Merged
legrego merged 7 commits intoelastic:masterfrom
legrego:fc/simplify-som
Jun 10, 2019
Merged

Feature Controls - Simplify Saved Objects Management UI Capabilities#38461
legrego merged 7 commits intoelastic:masterfrom
legrego:fc/simplify-som

Conversation

@legrego
Copy link
Member

@legrego legrego commented Jun 7, 2019 •
edited
Loading

Summary

This is a prerequisite to to implementing the Copy To Space API.

This simplifies the Saved Objects Management UI Capabilities by changing the capabilities from being type-specific, to just feature specific.

Previously:

uiCapabilities: {
  savedObjectsManagement: {
     dashboard: {
       read: true,
       edit: true,
       delete: true
     },
     discover: {
       read: true,
       edit: true,
       delete: true
     },
    canvas: {
       read: true,
       edit: true,
       delete: true
    },
    // etc
  }
}

Now:

uiCapabilities: {
  savedObjectsManagement: {
     read: true,
     edit: true,
     delete: true
  }
}

@legrego legrego mentioned this pull request Jun 7, 2019
Merged
@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 7, 2019

💔 Build Failed

@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 10, 2019

💚 Build Succeeded

legrego
legrego commented Jun 10, 2019
View reviewed changes
Copy link
Member Author

@legrego legrego left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pointed out opportunities to further simplify the UI components. I didn't undertake that effort yet, but I can if we find benefit to doing so. I wasn't sure if we'd want that flexibility in the future, but that alone might be reason enough to simplify now
edit: done

@legrego legrego marked this pull request as ready for review June 10, 2019 16:21
@legrego legrego requested a review from a team as a code owner June 10, 2019 16:21
@legrego legrego added Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t// Feature:Security/Feature Controls Platform Security - Spaces & Role Mgmt feature controls labels Jun 10, 2019
@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 10, 2019

Pinging @elastic/kibana-security

@legrego legrego added the release_note:skip Skip the PR/issue when compiling release notes label Jun 10, 2019
@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 10, 2019

💚 Build Succeeded

@legrego legrego added the review label Jun 10, 2019
@legrego legrego requested a review from kobelb June 10, 2019 20:01
@kobelb
Copy link
Contributor

kobelb commented Jun 10, 2019

ACK: reviewing right now

kobelb
kobelb reviewed Jun 10, 2019
View reviewed changes
...kibana/public/management/sections/objects/components/objects_table/components/table/table.js
unableToDeleteSavedObjectTypes.length > 0 ? `Unable to delete ${unableToDeleteSavedObjectTypes.join(', ')}` : undefined
this.props.canDelete
? undefined
: i18n.translate(
Copy link
Contributor

@kobelb kobelb Jun 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

kobelb
kobelb approved these changes Jun 10, 2019
View reviewed changes
Copy link
Contributor

@kobelb kobelb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green CI

@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 10, 2019

💚 Build Succeeded

@legrego legrego merged commit ee27bc4 into elastic:master Jun 10, 2019
@legrego legrego mentioned this pull request Jun 10, 2019
Merged
@legrego legrego deleted the fc/simplify-som branch June 10, 2019 22:09
legrego added a commit to legrego/kibana that referenced this pull request Jun 10, 2019
@legrego
Feature Controls - Simplify Saved Objects Management UI Capabilities (e…
d30cc45 
…lastic#38461)

* start simplifying saved objects management UI Capabilities

* update tests

* simplify UI

* address PR feedback

* remove savedObjectsManagement UI Capabilities tests
legrego added a commit that referenced this pull request Jun 10, 2019
@legrego
[7.x] Feature Controls - Simplify Saved Objects Management UI Capabil…
2fd33c9 
…ities (#38461) (#38618)

* start simplifying saved objects management UI Capabilities

* update tests

* simplify UI

* address PR feedback

* remove savedObjectsManagement UI Capabilities tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kobelb kobelb kobelb approved these changes

Assignees

No one assigned

Labels

Feature:Security/Feature Controls Platform Security - Spaces & Role Mgmt feature controls release_note:skip Skip the PR/issue when compiling release notes review Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t//

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@legrego @elasticmachine @kobelb