Skip to content

[ML] Job creator service#38083

Merged
jgowdyelastic merged 25 commits intoelastic:feature-new-ml-job-wizardsfrom
jgowdyelastic:job-creator-service2
Jun 6, 2019
Merged

[ML] Job creator service#38083
jgowdyelastic merged 25 commits intoelastic:feature-new-ml-job-wizardsfrom
jgowdyelastic:job-creator-service2

Conversation

@jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Jun 5, 2019

Summary

A small collection of classes for creating and running jobs which will be used by all new job creation pages.
Example usage:

const jobCreator = new MultiMetricJobCreator(
  indexPattern,
  savedSearch,
  query
);
jobCreator.addDetector(mean, field); // agg and field objects not shown here
jobCreator.setSplitField(splitField); // splitField object not shown here
jobCreator.bucketSpan = '15m';
jobCreator.setDuration(1540684800000, 1541943060000);
jobCreator.jobId = 'my_new_job';
jobCreator.subscribeToProgress((p: number) => {
  console.log('progress ', p); // log out the progress as the job is run
});
await jobCreator.createAndStartJob();

The job progress is broadcast using an observable, chart elements will subscribe so they can update themselves as the job is running.
Single, multi and population job creators each extend the base JobCreator class and implement the detector creation methods in their own way.

TODO in follow up PR:

  • Improve job creation and starting error handling
  • Add tests

@jgowdyelastic jgowdyelastic added review :ml v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.3.0 labels Jun 5, 2019
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner June 5, 2019 09:37
@jgowdyelastic jgowdyelastic self-assigned this Jun 5, 2019
@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 5, 2019

Pinging @elastic/ml-ui

peteharverson
peteharverson approved these changes Jun 5, 2019
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgowdyelastic
Copy link
Member Author

jgowdyelastic commented Jun 5, 2019

retest

@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 5, 2019

💔 Build Failed

alvarezmelissa87
alvarezmelissa87 approved these changes Jun 5, 2019
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡️

@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 5, 2019

💔 Build Failed

@jgowdyelastic jgowdyelastic force-pushed the job-creator-service2 branch from 0d1e1a6 to d06994d Compare June 5, 2019 14:21
@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 5, 2019

💔 Build Failed

@jgowdyelastic
Copy link
Member Author

jgowdyelastic commented Jun 5, 2019

retest

@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 5, 2019

💔 Build Failed

@jgowdyelastic
Copy link
Member Author

jgowdyelastic commented Jun 5, 2019

retest

@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 5, 2019

💔 Build Failed

@jgowdyelastic
Copy link
Member Author

jgowdyelastic commented Jun 5, 2019

retest

@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 5, 2019

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 6, 2019

💔 Build Failed

@jgowdyelastic
Copy link
Member Author

jgowdyelastic commented Jun 6, 2019

retest

@jgowdyelastic
removing unrelated files
07b8a00
@jgowdyelastic
removing unrelated html
a942c7f
@jgowdyelastic
adding aggregations to single metric jobs
ce7332b
@jgowdyelastic
refactoring and removing comented out code
ec32ff8
@jgowdyelastic
removing include
0ccbbea
@jgowdyelastic
using ms for interval
16e988d
@jgowdyelastic
adding comments
2536310
@jgowdyelastic
removing unused file
e242a88
@jgowdyelastic
fixing git weirdness
a11af3d
@jgowdyelastic
changing include path to fix CI failure
e9b59a1
@jgowdyelastic
fixes progress for jobs which haven't got a latest_record_timestamp yet
0d7611e
@jgowdyelastic
changes based on review
a08bc84
@jgowdyelastic
using agg name enum for aggMap key
b1abb56
@jgowdyelastic
fixing test
54dbca6
@jgowdyelastic
fixing case of cardinality type
395033c
@jgowdyelastic
adding missing type
b898e15
@jgowdyelastic
changes following review
fa43521
@jgowdyelastic
using relative path for SavedSeard type include
8675533
@jgowdyelastic
adding copy of kibana's SavedSearch type
9eaf4bc
@jgowdyelastic
reverting previous include change
1ef2825
@jgowdyelastic
removing unused include
49fbc41
@jgowdyelastic jgowdyelastic force-pushed the job-creator-service2 branch from 880997e to 49fbc41 Compare June 6, 2019 10:32
@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 6, 2019

💔 Build Failed

@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 6, 2019

💚 Build Succeeded

@jgowdyelastic jgowdyelastic merged commit 4f79ae6 into elastic:feature-new-ml-job-wizards Jun 6, 2019
@jgowdyelastic jgowdyelastic deleted the job-creator-service2 branch June 6, 2019 11:58
@jgowdyelastic jgowdyelastic mentioned this pull request Jul 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@peteharverson peteharverson peteharverson approved these changes

@walterra walterra Awaiting requested review from walterra

Assignees

@jgowdyelastic jgowdyelastic

Labels

:ml release_note:skip Skip the PR/issue when compiling release notes review v7.3.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jgowdyelastic @elasticmachine @alvarezmelissa87 @peteharverson