[Code] fix url and encoding for java langserver on Windows#38064
Merged
Conversation
zfy0701
approved these changes
Jun 5, 2019
zfy0701
suggested changes
Jun 5, 2019
| '-Dosgi.bundles.defaultStartLevel=4', | ||
| '-Declipse.product=org.elastic.jdt.ls.core.product', | ||
| '-Dlog.level=ALL', | ||
| '-Dfile.encoding=utf8', |
Contributor
There was a problem hiding this comment.
let's hold this a little bit
Contributor
💚 Build Succeeded |
spacedragon
approved these changes
Jun 5, 2019
Contributor
spacedragon
left a comment
spacedragon
left a comment
There was a problem hiding this comment.
verified, should be fine.
zfy0701
approved these changes
Jun 5, 2019
Poytr1
pushed a commit
to Poytr1/kibana
that referenced
this pull request
Jun 5, 2019
This was referenced Jun 5, 2019
Poytr1
pushed a commit
to Poytr1/kibana
that referenced
this pull request
Jun 5, 2019
Poytr1
pushed a commit
that referenced
this pull request
Jun 5, 2019
Poytr1
pushed a commit
that referenced
this pull request
Jun 5, 2019
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolve: https://github.com/elastic/code/issues/1283
Resolve: https://github.com/elastic/code/issues/1288