Skip to content

[Code] use empty placeholder when search filters returns empty results #38006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mw-ding merged 1 commit into from
Jun 4, 2019
Merged

[Code] use empty placeholder when search filters returns empty results #38006

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 19 additions & 21 deletions x-pack/plugins/code/public/components/search_page/search.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,32 +177,30 @@ class SearchPage extends React.PureComponent<Props, State> {
<div className="codeContainer__search--results">{resultComps}</div>
</div>
);
} else if (
scope === SearchScope.DEFAULT &&
documentSearchResults &&
(documentSearchResults.total > 0 || languages!.size > 0 || repositories!.size > 0)
) {
} else if (scope === SearchScope.DEFAULT && documentSearchResults) {
const { stats, results } = documentSearchResults!;
const { total, from, to, page, totalPage } = stats!;
languageStats = stats!.languageStats;
repoStats = stats!.repoStats;
const statsComp = (
<EuiTitle size="m">
<h1>
Showing {total > 0 ? from : 0} - {to} of {total} results.
</h1>
</EuiTitle>
);
mainComp = (
<div className="codeContainer__search--inner">
{statsComp}
<EuiSpacer />
<div className="codeContainer__search--results">
<CodeResult results={results!} />
if (documentSearchResults.total > 0) {
const statsComp = (
<EuiTitle size="m">
<h1>
Showing {total > 0 ? from : 0} - {to} of {total} results.
</h1>
</EuiTitle>
);
mainComp = (
<div className="codeContainer__search--inner">
{statsComp}
<EuiSpacer />
<div className="codeContainer__search--results">
<CodeResult results={results!} />
</div>
<Pagination query={this.props.query} totalPage={totalPage} currentPage={page - 1} />
</div>
<Pagination query={this.props.query} totalPage={totalPage} currentPage={page - 1} />
</div>
);
);
}
}

return (
Expand Down