Skip to content

Update import saved objects API docs to use curl examples#37997

Merged
mikecote merged 2 commits into
elastic:masterfrom
mikecote:update-import-docs
Jun 5, 2019
Merged

Update import saved objects API docs to use curl examples#37997
mikecote merged 2 commits into
elastic:masterfrom
mikecote:update-import-docs

Conversation

@mikecote
Copy link
Copy Markdown
Contributor

@mikecote mikecote commented Jun 4, 2019

In this PR, I'm making modifications to the saved objects import and resolve import errors API documentation. I am changing the examples to use curl w/ an external file. It seems more the path users would go when interacting with these APIs and the previous examples didn't translate easily to curl.

@mikecote mikecote added review Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// Feature:Saved Objects v8.0.0 v7.2.0 labels Jun 4, 2019
@mikecote mikecote self-assigned this Jun 4, 2019
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-platform

Copy link
Copy Markdown

@LeeDr LeeDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(Mike helped me do some tests of _export and _import and updated the docs to make it clearer)

@elasticmachine
Copy link
Copy Markdown
Contributor

💔 Build Failed

@mikecote
Copy link
Copy Markdown
Contributor Author

mikecote commented Jun 4, 2019

retest

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@mikecote mikecote merged commit a537aae into elastic:master Jun 5, 2019
mikecote added a commit to mikecote/kibana that referenced this pull request Jun 5, 2019
)

* Remove copy as curl

* Update import docs to use curl examples
mikecote added a commit to mikecote/kibana that referenced this pull request Jun 5, 2019
)

* Remove copy as curl

* Update import docs to use curl examples
mikecote added a commit that referenced this pull request Jun 5, 2019
…38098)

* Remove copy as curl

* Update import docs to use curl examples
mikecote added a commit that referenced this pull request Jun 5, 2019
…38099)

* Remove copy as curl

* Update import docs to use curl examples
patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request May 6, 2026
)

* Remove copy as curl

* Update import docs to use curl examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Saved Objects review Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// v7.2.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants