Skip to content

[Uptime] Remove deprecated date_histogram field from ES queries#37995

Merged
justinkambic merged 1 commit into
elastic:masterfrom
justinkambic:uptime_deprecated-date-histogram-field
Jun 5, 2019
Merged

[Uptime] Remove deprecated date_histogram field from ES queries#37995
justinkambic merged 1 commit into
elastic:masterfrom
justinkambic:uptime_deprecated-date-histogram-field

Conversation

@justinkambic
Copy link
Copy Markdown
Contributor

@justinkambic justinkambic commented Jun 4, 2019

Summary

We were previously using the interval field for date_histogram queries. This field is deprecated (see below) and we should use fixed_interval instead going forward.

image

Testing

  1. Start up Heartbeat with several monitors.
  2. Open the Uptime app running this patch.
  3. Note that the snapshot component loads data ok.
    image
  4. Note that the bar series on the monitor list loads data ok.
    image

@justinkambic justinkambic added chore v8.0.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.3.0 labels Jun 4, 2019
@justinkambic justinkambic self-assigned this Jun 4, 2019
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jun 4, 2019

Pinging @elastic/uptime

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jun 4, 2019

💔 Build Failed

andrewvc
andrewvc approved these changes Jun 4, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewvc
Copy link
Copy Markdown
Contributor

andrewvc commented Jun 4, 2019 •
edited
Loading

jenkins, retest this please

(the last failed due to CI infrastructure being weird and not starting)

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jun 4, 2019

💚 Build Succeeded

@justinkambic justinkambic merged commit 1080dc4 into elastic:master Jun 5, 2019
justinkambic added a commit to justinkambic/kibana that referenced this pull request Jun 6, 2019
@justinkambic
Remove deprecated feature from elasticsearch queries. (elastic#37995)
b997590
justinkambic added a commit to justinkambic/kibana that referenced this pull request Jun 6, 2019
@justinkambic
Remove deprecated feature from elasticsearch queries. (elastic#37995)
531c8d1
This was referenced Jun 6, 2019
Merged
Merged
justinkambic added a commit that referenced this pull request Jun 6, 2019
@justinkambic
Remove deprecated feature from elasticsearch queries. (#37995) (#38288)
c78e4fc
@justinkambic
Copy link
Copy Markdown
Contributor Author

justinkambic commented Jun 6, 2019 •
edited
Loading

Backported to:

justinkambic added a commit that referenced this pull request Jun 7, 2019
@justinkambic
Remove deprecated feature from elasticsearch queries. (#37995) (#38287)
c647c71
@justinkambic justinkambic deleted the uptime_deprecated-date-histogram-field branch June 7, 2019 16:29
patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request May 6, 2026
@justinkambic
Remove deprecated feature from elasticsearch queries. (elastic#37995)
c77adcf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewvc andrewvc andrewvc approved these changes

Assignees

@justinkambic justinkambic

Labels

chore Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.2.0 v7.3.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@justinkambic @elasticmachine @andrewvc