[Canvas] Fixes broken elements in web logs sample data workpad#37931
Merged
Conversation
…ormatting in each element
cqliu1
added
bug
Contributor
|
Pinging @elastic/kibana-canvas |
w33ble
approved these changes
Jun 3, 2019
Contributor
w33ble
left a comment
w33ble
left a comment
There was a problem hiding this comment.
LGTM, the image changes make for a much nicer experience!
Worth backporting the changes you think? I'll leave it up to you.
Contributor
💚 Build Succeeded |
ryankeairns
approved these changes
Jun 4, 2019
Contributor
ryankeairns
left a comment
ryankeairns
left a comment
There was a problem hiding this comment.
👍 🌮 LGTM. The re-formatted expressions are much easier to read!
This was referenced Jun 4, 2019
cqliu1
added a commit
to cqliu1/kibana
that referenced
this pull request
Jun 4, 2019
…ic#37931) * Fixed broken elements in logs sample workpad. Cleaned up expression formatting in each element * Removed return characters at the beginning of expressions
cqliu1
added a commit
to cqliu1/kibana
that referenced
this pull request
Jun 4, 2019
…ic#37931) * Fixed broken elements in logs sample workpad. Cleaned up expression formatting in each element * Removed return characters at the beginning of expressions
cqliu1
added a commit
to cqliu1/kibana
that referenced
this pull request
Jun 4, 2019
…ic#37931) * Fixed broken elements in logs sample workpad. Cleaned up expression formatting in each element * Removed return characters at the beginning of expressions
cqliu1
added a commit
to cqliu1/kibana
that referenced
this pull request
Jun 4, 2019
…ic#37931) * Fixed broken elements in logs sample workpad. Cleaned up expression formatting in each element * Removed return characters at the beginning of expressions
cqliu1
added a commit
that referenced
this pull request
Jun 4, 2019
… (#38037) * Fixed broken elements in logs sample workpad. Cleaned up expression formatting in each element * Removed return characters at the beginning of expressions
cqliu1
added a commit
that referenced
this pull request
Jun 4, 2019
… (#38036) * Fixed broken elements in logs sample workpad. Cleaned up expression formatting in each element * Removed return characters at the beginning of expressions
cqliu1
added a commit
that referenced
this pull request
Jun 4, 2019
… (#38034) * Fixed broken elements in logs sample workpad. Cleaned up expression formatting in each element * Removed return characters at the beginning of expressions
cqliu1
added a commit
that referenced
this pull request
Jun 4, 2019
… (#38035) * Fixed broken elements in logs sample workpad. Cleaned up expression formatting in each element * Removed return characters at the beginning of expressions
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
…ic#37931) * Fixed broken elements in logs sample workpad. Cleaned up expression formatting in each element * Removed return characters at the beginning of expressions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Four of the elements at the top of the logs workpad were broken. This PR fixes those elements and also cleans up the formatting in the expressions to make them more readable.
Before
After
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers