Skip to content

Fix bad type import from interpreter.#37741

Merged
lukeelmers merged 2 commits into
elastic:masterfrom
lukeelmers:fix/bad-interpreter-import
Jun 4, 2019
Merged

Fix bad type import from interpreter.#37741
lukeelmers merged 2 commits into
elastic:masterfrom
lukeelmers:fix/bad-interpreter-import

Conversation

@lukeelmers
Copy link
Copy Markdown
Contributor

The original import was unintentionally @ts-ignored, so when the types file was removed, errors got swallowed.

@lukeelmers lukeelmers added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.3.0 labels May 31, 2019
@lukeelmers lukeelmers requested a review from joshdover May 31, 2019 21:30
@elasticmachine

This comment has been minimized.

@joshdover
Copy link
Copy Markdown
Contributor

@lukeelmers can we get this merged soon? node script/jest --watch still is broken due to this.

@lukeelmers
Copy link
Copy Markdown
Contributor Author

@joshdover Yep, I'm looking at those remaining CI issues right now; will update shortly

@joshdover
Copy link
Copy Markdown
Contributor

Thanks!

@elasticmachine

This comment has been minimized.

@lukeelmers lukeelmers force-pushed the fix/bad-interpreter-import branch from be3c7c7 to 637fc60 Compare June 4, 2019 21:46
@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@lukeelmers lukeelmers merged commit 44964d1 into elastic:master Jun 4, 2019
@lukeelmers lukeelmers deleted the fix/bad-interpreter-import branch June 4, 2019 23:35
lukeelmers added a commit to lukeelmers/kibana that referenced this pull request Jun 4, 2019
patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes v7.3.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants