Fixing isMigrated bug, when migrations failed we incorrectly ignored it.#37674
Merged
Conversation
Prior to this change, when migrations failed (for example when a .kibana_1 index already exists and no alias does) the awaitMigration promise would resolve incorrectly. This allowed subsequent plugins, including Spaces, to proceed using the SavedObjectsClient/Repository to create documents. This commonly caused a .kibana index to be created, which would then block the creation of a .kibana alias, and everything would grind to a halt.
Contributor
💚 Build Succeeded |
chrisdavies
approved these changes
Jun 3, 2019
Contributor
chrisdavies
left a comment
chrisdavies
left a comment
There was a problem hiding this comment.
LGTM. Didn't pull down / run.
joshdover
approved these changes
Jun 4, 2019
Contributor
joshdover
left a comment
joshdover
left a comment
There was a problem hiding this comment.
Can we add a test so we don't break this again?
This was referenced Jun 4, 2019
Merged
kobelb
added a commit
to kobelb/kibana
that referenced
this pull request
Jun 4, 2019
…it. (elastic#37674) Prior to this change, when migrations failed (for example when a .kibana_1 index already exists and no alias does) the awaitMigration promise would resolve incorrectly. This allowed subsequent plugins, including Spaces, to proceed using the SavedObjectsClient/Repository to create documents. This commonly caused a .kibana index to be created, which would then block the creation of a .kibana alias, and everything would grind to a halt.
kobelb
added a commit
to kobelb/kibana
that referenced
this pull request
Jun 4, 2019
…it. (elastic#37674) Prior to this change, when migrations failed (for example when a .kibana_1 index already exists and no alias does) the awaitMigration promise would resolve incorrectly. This allowed subsequent plugins, including Spaces, to proceed using the SavedObjectsClient/Repository to create documents. This commonly caused a .kibana index to be created, which would then block the creation of a .kibana alias, and everything would grind to a halt.
kobelb
added a commit
to kobelb/kibana
that referenced
this pull request
Jun 4, 2019
…it. (elastic#37674) Prior to this change, when migrations failed (for example when a .kibana_1 index already exists and no alias does) the awaitMigration promise would resolve incorrectly. This allowed subsequent plugins, including Spaces, to proceed using the SavedObjectsClient/Repository to create documents. This commonly caused a .kibana index to be created, which would then block the creation of a .kibana alias, and everything would grind to a halt.
kobelb
added a commit
that referenced
this pull request
Jun 4, 2019
…it. (#37674) (#38041) Prior to this change, when migrations failed (for example when a .kibana_1 index already exists and no alias does) the awaitMigration promise would resolve incorrectly. This allowed subsequent plugins, including Spaces, to proceed using the SavedObjectsClient/Repository to create documents. This commonly caused a .kibana index to be created, which would then block the creation of a .kibana alias, and everything would grind to a halt.
kobelb
added a commit
that referenced
this pull request
Jun 4, 2019
…it. (#37674) (#38042) Prior to this change, when migrations failed (for example when a .kibana_1 index already exists and no alias does) the awaitMigration promise would resolve incorrectly. This allowed subsequent plugins, including Spaces, to proceed using the SavedObjectsClient/Repository to create documents. This commonly caused a .kibana index to be created, which would then block the creation of a .kibana alias, and everything would grind to a halt.
kobelb
added a commit
that referenced
this pull request
Jun 4, 2019
…it. (#37674) (#38043) Prior to this change, when migrations failed (for example when a .kibana_1 index already exists and no alias does) the awaitMigration promise would resolve incorrectly. This allowed subsequent plugins, including Spaces, to proceed using the SavedObjectsClient/Repository to create documents. This commonly caused a .kibana index to be created, which would then block the creation of a .kibana alias, and everything would grind to a halt.
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 6, 2026
…it. (elastic#37674) Prior to this change, when migrations failed (for example when a .kibana_1 index already exists and no alias does) the awaitMigration promise would resolve incorrectly. This allowed subsequent plugins, including Spaces, to proceed using the SavedObjectsClient/Repository to create documents. This commonly caused a .kibana index to be created, which would then block the creation of a .kibana alias, and everything would grind to a halt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this change, when migrations failed (for example when a
.kibana_1index already exists and no.kibanaalias does) theawaitMigrationpromise would resolve incorrectly. This allowed subsequent plugins,
including Spaces, to proceed using the SavedObjectsClient/Repository
to create documents. This commonly caused a
.kibanaindex to be created,which would then block the creation of a
.kibanaalias, and everythingwould grind to a halt.
"Release Note: Resolving issue which occurs when migrations are partially complete and a new Kibana instance starts up. The migrations weren't blocking operations which could cause the creation of a
.kibanaindex."