[7.x] [feat] create additional http servers (#36804)#37517
Merged
toddself merged 2 commits intoelastic:7.xfrom May 31, 2019
Merged
[7.x] [feat] create additional http servers (#36804)#37517toddself merged 2 commits intoelastic:7.xfrom
toddself merged 2 commits intoelastic:7.xfrom
Conversation
Contributor
💔 Build Failed |
toddself
added
the
Team:Core
Contributor
|
Pinging @elastic/kibana-platform |
Contributor
💔 Build Failed |
toddself
force-pushed
the
backport/7.x/pr-36804
branch
from
19466ed to
2385c87
Compare
Contributor
💔 Build Failed |
* [feat] create additional http servers allow for additional http servers to be created, tracked and returned * respond to pr feedback * tweak test * update documentation * destructure port, remove unnecessary imports * [fix] export correct type * [feat] expose createNewServer to plugins * [fix] respond to pr feedback * todo: add schema validation & integration test * use reach * [fix] use validateKey to validate partial * [fix] change config shadowing * check kibana port & prevent shadowing * centralize start/stop for servers, add integration test * remove unnecessary property * never forget your await * remove option to pass config into start * fix pr feedback * fix documentation * fix test failures
toddself
force-pushed
the
backport/7.x/pr-36804
branch
from
2385c87 to
c2d0713
Compare
Contributor
💚 Build Succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: