[draft][lens] Fix drag / drop tests in lens#36449
Closed
chrisdavies wants to merge 8 commits intoelastic:feature/lensfrom
Closed
[draft][lens] Fix drag / drop tests in lens#36449chrisdavies wants to merge 8 commits intoelastic:feature/lensfrom
chrisdavies wants to merge 8 commits intoelastic:feature/lensfrom
Conversation
Contributor
💚 Build Succeeded |
Contributor
|
I think we don't need this, the hook invariant errors seem to happen because we have a separate package.json and node_modules which somehow pulls in a second react version. Try removing Can we get rid of our local package.json and just bump the elastic-charts version on the global level? This is |
Contributor
|
See #36456 |
Contributor
Author
|
Closing in lieu of Joe's PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the workaround we discussed to get drag / drop tests passing again. I don't know why GitHub is showing 8 commits. I made only one. The diff appears to be correct, though.