Skip to content

Adding hapi-auth-cookie to Kibana's root package.json#35420

Merged
kobelb merged 1 commit intoelastic:masterfrom
kobelb:hapi-auth-cookie-dep
Apr 22, 2019
Merged

Adding hapi-auth-cookie to Kibana's root package.json#35420
kobelb merged 1 commit intoelastic:masterfrom
kobelb:hapi-auth-cookie-dep

Conversation

@kobelb
Copy link
Contributor

@kobelb kobelb commented Apr 22, 2019

With the introduction of #34631
OSS Kibana now has a dependency on hapi-auth-cookie, but it's missing
from the package.json

Resolves #35416

With the introduction of elastic#34631
OSS Kibana now has a dependency on hapi-auth-cookie, but it's missing
from the package.json
@kobelb kobelb added release_note:skip Skip the PR/issue when compiling release notes v8.0.0 v7.2.0 labels Apr 22, 2019
@kobelb kobelb requested a review from mshustov April 22, 2019 17:14
@tylersmalley
Copy link
Member

No yarn.lock changes?

@kobelb
Copy link
Contributor Author

kobelb commented Apr 22, 2019

No yarn.lock changes?

There are not... I just re-ran yarn kbn bootstrap and I'm not seeing any changes. My understanding is that the yarn.lock in the root reflects the dependencies for the default distribution. Since x-pack/package.json already has the same dependency listed, it's already installed. However, when we build the OSS archive, we're somehow excluding these x-pack only dependencies, which is where the problem lies.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@kobelb kobelb merged commit 77b6a9a into elastic:master Apr 22, 2019
@kobelb kobelb deleted the hapi-auth-cookie-dep branch April 22, 2019 18:32
kobelb added a commit to kobelb/kibana that referenced this pull request Apr 22, 2019
With the introduction of elastic#34631
OSS Kibana now has a dependency on hapi-auth-cookie, but it's missing
from the package.json
kobelb added a commit that referenced this pull request Apr 22, 2019
With the introduction of #34631
OSS Kibana now has a dependency on hapi-auth-cookie, but it's missing
from the package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes v7.2.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error starting Kibana OSS

3 participants