[CCR] Allow user to use CCR when security is not enabled.#35333
Merged
cjcenizal merged 2 commits intoelastic:masterfrom Apr 19, 2019
Merged
[CCR] Allow user to use CCR when security is not enabled.#35333cjcenizal merged 2 commits intoelastic:masterfrom
cjcenizal merged 2 commits intoelastic:masterfrom
Conversation
cjcenizal
added
bug
Contributor
|
Pinging @elastic/es-ui |
Contributor
Author
|
I got word from Shane that security is not required for CCR, so I'm going to update this change to just allow the user to use the UI if security is disabled. |
jen-huang
approved these changes
Apr 18, 2019
Contributor
jen-huang
left a comment
jen-huang
left a comment
There was a problem hiding this comment.
Code LGTM! Thanks for fixing this!
cjcenizal
changed the title
cjcenizal
force-pushed
the
bug/ccr-permissions-security-disabled
branch
from
f304f51 to
b77940b
Compare
jen-huang
approved these changes
Apr 18, 2019
Contributor
jen-huang
left a comment
jen-huang
left a comment
There was a problem hiding this comment.
Revised code dropping security requirement LGTM!
Contributor
💚 Build Succeeded |
This was referenced Apr 19, 2019
cjcenizal
added a commit
to cjcenizal/kibana
that referenced
this pull request
Apr 19, 2019
cjcenizal
added a commit
to cjcenizal/kibana
that referenced
this pull request
Apr 19, 2019
cjcenizal
added a commit
to cjcenizal/kibana
that referenced
this pull request
Apr 19, 2019
cjcenizal
added a commit
that referenced
this pull request
Apr 19, 2019
cjcenizal
added a commit
that referenced
this pull request
Apr 19, 2019
cjcenizal
added a commit
that referenced
this pull request
Apr 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #33356
When we shipped CCR in 6.7 we shipped it with a notification to the user when their permissions were inadequate.
Unfortunately, this logic contained a bug which manifested when security was disabled. In such a scenario, the user would see this unhelpful error:
This change allows the user to use CCR when security is disabled.
Outdated info below, preserved for posterity
This PR updates the API endpoint to check if security is enabled and notifies the client if it isn't, in which case the user is informed of the missing requirement: