Skip to content

Self Review items for Export to CSV from Saved Object #34877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tsullivan merged 3 commits into from
Apr 10, 2019
Merged

Self Review items for Export to CSV from Saved Object #34877

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eed5f3f
self review
tsullivan Apr 10, 2019
7cffc9a
rename types.d.ts to index
tsullivan Apr 10, 2019
f2c1a79
fix imports
tsullivan Apr 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion x-pack/plugins/reporting/export_types/csv/server/lib/flatten_hit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

import _ from 'lodash';

// FIXME this logic should be re-used with Discover
// TODO this logic should be re-used with Discover
export function createFlattenHit(fields, metaFields, conflictedTypesFields) {
const flattenSource = (flat, obj, keyPrefix) => {
keyPrefix = keyPrefix ? keyPrefix + '.' : '';
Expand Down
0 ...ort_types/csv_from_savedobject/types.d.ts → ...ort_types/csv_from_savedobject/index.d.ts
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion x-pack/plugins/reporting/export_types/csv_from_savedobject/server/create_job/create_job.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import {
SearchPanel,
TimeRangeParams,
VisObjectAttributesJSON,
} from '../../types';
} from '../../';
import { createGenerateCsv } from '../lib/generate_csv';
import { createJobSearch } from './create_job_search';

Expand Down
2 changes: 1 addition & 1 deletion ...lugins/reporting/export_types/csv_from_savedobject/server/create_job/create_job_search.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import {
SavedSearchObjectAttributes,
SearchPanel,
TimeRangeParams,
} from '../../types';
} from '../../';

interface SearchPanelData {
title: string;
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/reporting/export_types/csv_from_savedobject/server/lib/generate_csv.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { Request } from 'hapi';
// @ts-ignore
import { createTaggedLogger } from '../../../../server/lib';
import { KbnServer, Logger } from '../../../../types';
import { SearchPanel, VisPanel } from '../../types';
import { SearchPanel, VisPanel } from '../../';
import { generateCsvSearch } from './generate_csv_search';

interface FakeRequest {
Expand Down
6 changes: 3 additions & 3 deletions x-pack/plugins/reporting/export_types/csv_from_savedobject/server/lib/generate_csv_search.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import {
SearchRequest,
SearchSource,
TimeRangeParams,
} from '../../types';
} from '../../';
import { getDataSource } from './get_data_source';

interface SavedSearchGeneratorResult {
Expand All @@ -42,7 +42,7 @@ interface GenerateCsvParams {
formatsMap: FormatsMap;
metaFields: string[]; // FIXME not sure what this is for
conflictedTypesFields: string[]; // FIXME not sure what this is for
cancellationToken: any; // FIXME not sure how to do anything with this
cancellationToken: any;
settings: {
separator: string;
quoteValues: boolean;
Expand Down Expand Up @@ -181,7 +181,7 @@ export async function generateCsvSearch(
formatsMap: new Map(), // there is no field formatting in this API; this is required for generateCsv
metaFields: [],
conflictedTypesFields: [],
cancellationToken: [],
cancellationToken: [], // TODO
settings: {
...uiSettings,
maxSizeBytes: config.get('xpack.reporting.csv.maxSizeBytes'),
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/reporting/export_types/csv_from_savedobject/server/lib/get_data_source.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import {
SavedObjectReference,
SavedSearchObjectAttributesJSON,
SearchSource,
} from '../../types';
} from '../../';

export async function getDataSource(
savedObjectsClient: any,
Expand Down