Date field formatted via docvalue_fields; none else formatted#34584
Merged
tsullivan merged 9 commits intoelastic:feature/reporting/csv-export-panel-actionfrom Apr 10, 2019
Conversation
tsullivan
added
the
zDeprecated Feature:Reporting
This comment has been minimized.
This comment has been minimized.
tsullivan
force-pushed
the
feature/reporting/csv-export-panel-action-nofmt
branch
from
3d2a122 to
5355b70
Compare
Member
Author
|
Please ignore ^^ I accidentally merged master into this. This is targeted to a feature branch |
…anel-action' into feature/reporting/csv-export-panel-action-nofmt
joelgriffith
reviewed
Apr 5, 2019
| callEndpoint: EndpointCaller; | ||
| fields: string[]; | ||
| formatsMap: FormatsMap; | ||
| formatsMap: FormatsMap, |
Contributor
There was a problem hiding this comment.
Think we'll want a semicolon here (unless the new linter doesn't think so)
joelgriffith
approved these changes
Apr 5, 2019
Contributor
joelgriffith
left a comment
joelgriffith
left a comment
There was a problem hiding this comment.
Small fix on the GenerateCsvParams interface, otherwise looks good
Contributor
💔 Build Failed |
…anel-action' into feature/reporting/csv-export-panel-action-nofmt
Contributor
💚 Build Succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A late change to the feature branch made the field values go through formatting, same as our current CSV export.
This revises the behavior to not format any values, and display as they are in the
_sourcedata. The exception is the index pattern's date field, which is the left most column in the export (but is also optional for index patterns). Formatting of the date field uses Elasticsearch doc_values and passesstrict_date_timeas the formatting parameter.Screenshots:
Steps to make these:
Before:
After:
