[@kbn/expect] "fork" expect.js into repo #33761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
review
Team:Operations
Contributor
|
Pinging @elastic/kibana-operations |
This comment has been minimized.
This comment has been minimized.
Contributor
💚 Build Succeeded |
jbudz
approved these changes
Mar 25, 2019
Contributor
|
Any consideration for moving to another assertion library that is supported? A codemod to replace expect.js with, say, chai, may not be super diffucult, and then we don't need a fork. |
Contributor
Author
|
@w33ble I'm not saying we can't do that, but I think it would probably be more productive to go through and finish migrating all the existing tests to Jest. Right now though I'm trying to collect assertion counts for the functional tests, which I don't think migrating to chai would help with. |
Contributor
💚 Build Succeeded |
This was referenced Mar 25, 2019
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Mar 25, 2019
* [@kbn/expect] "fork" expect.js into repo * [eslint] autofix references to expect.js * [tslint] autofix all expect.js imports * now that expect.js is in strict mode, avoid reassigning fn.length
This was referenced Mar 25, 2019
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Mar 25, 2019
* [@kbn/expect] "fork" expect.js into repo * [eslint] autofix references to expect.js * [tslint] autofix all expect.js imports * now that expect.js is in strict mode, avoid reassigning fn.length
spalger
pushed a commit
that referenced
this pull request
Mar 25, 2019
spalger
pushed a commit
that referenced
this pull request
Mar 25, 2019
Contributor
Author
joelgriffith
pushed a commit
that referenced
this pull request
Mar 27, 2019
* [@kbn/expect] "fork" expect.js into repo * [eslint] autofix references to expect.js * [tslint] autofix all expect.js imports * now that expect.js is in strict mode, avoid reassigning fn.length
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several improvements we'd like to make to expect.js, but the upstream repo is basically done. There are many open PRs and the last commit was in January 2015, so I think we should pull the library into our repo so we can tweak it.
Custom eslint/tslint rules are included to rewrite
import expect from 'expect.js'toimport expect from '@kbn/expect'.