Fix plugin generator package.json paths#33728
Merged
rashidkpc merged 2 commits intoelastic:masterfrom Mar 26, 2019
Merged
Conversation
rashidkpc
force-pushed
the
fix/plugin_generator
branch
from
5ed56ef to
33d3ff0
Compare
Contributor
💚 Build Succeeded |
njd5475
approved these changes
Mar 25, 2019
Contributor
njd5475
left a comment
njd5475
left a comment
There was a problem hiding this comment.
I was able to successfully run scripts/generate_plugin.js with these changes, LGTM.
Contributor
💚 Build Succeeded |
joelgriffith
pushed a commit
that referenced
this pull request
Mar 27, 2019
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Mar 28, 2019
This was referenced Mar 28, 2019
spalger
pushed a commit
that referenced
this pull request
Mar 28, 2019
Contributor
|
7.x/7.1: b1503bc |
spalger
pushed a commit
that referenced
this pull request
Mar 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the paths in the plugin generator's
package.jsonso it works again 🔌Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11
- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers