Merged
Conversation
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
|
Looks like Snapshot failure, going to try and push up fixes. |
Member
Author
|
Just pushed up the x-pack snapshot failures which should be the last of the updates needed. I'm signing off now so if anyone else wants to pick up from there, feel free. :) |
Contributor
💚 Build Succeeded |
walterra
approved these changes
Mar 22, 2019
Contributor
walterra
left a comment
walterra
left a comment
There was a problem hiding this comment.
iconType related changes LGTM. Just a more general EUI related thought: Would it make sense if EUI exported an Enum with the iconType names? Then you could do something like iconTypeEnum.search instead of 'search' as IconType.
kobelb
approved these changes
Mar 22, 2019
Contributor
|
|
snide
pushed a commit
to snide/kibana
that referenced
this pull request
Mar 28, 2019
* Updates EUI to 9.5.0 * Remove duplicate type * Updates snapshots and fixes a few type errors * Updates x-pack snapshots
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades EUI to 9.5 and fixes any associated breaks.
https://github.com/elastic/eui/blob/master/CHANGELOG.md#950