Skip to content

Merge elastic code plugin to main Kibana for 7.1 (2nd Review) #33438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 806 commits into from
Apr 23, 2019
Merged

Merge elastic code plugin to main Kibana for 7.1 (2nd Review) #33438

merged 806 commits into from
Apr 23, 2019

Conversation

@zfy0701
Copy link
Contributor

@zfy0701 zfy0701 commented Mar 18, 2019 •
edited
Loading

Previous review: #27012

Main Code position: https://github.com/elastic/kibana/blob/feature/merge-code/x-pack/plugins/code

Security: https://github.com/elastic/kibana/blob/feature/merge-code/x-pack/plugins/code/index.ts#L54

Know issues:

  • Java Cross reference is not working in Linux
  • UI issues in internet explorer
  • Typescript Indexing take few hours for large repo like Kibana
  • Minor style issue at dark mode
  • Some java files don't have code intelligence if they are in non-src directory

for full list of issues see:
https://github.com/elastic/code/issues

Pengcheng Xu and others added 30 commits February 20, 2019 13:06
[Code] Use system JDK if it is available (#31389)
7a7aff8
@mw-ding
[Code] fix functional tests (#31555)
7db0996
@WangQianliang
fix(code/frontend): main page (#29811)
300783c
@spacedragon
[Code] fix find references style (#30911)
0dd40c8
@zfy0701
[Code]: properly reconnect when langserver is down and clean up logs, f…
9d36039 
…ix #839, #891 (#30601)
@WangQianliang
fix(code/frontend): wider clickable area for file and structure node (#…
71257ce 
…31176)
@WangQianliang
fix(code/frontend): fix project filter press enter location change (#…
d537525 
…29919)
@zfy0701
Code: move all non-error LSP logging to debug level
4d699b5
@daveyholler @zfy0701
[Code] Dark mode cleanup (#31208)
4acf2a9
@zfy0701
Merge remote-tracking branch 'origin/master' into feature/merge-code
240eac6
@WangQianliang @zfy0701
fix(code/frontend): fix componentWillMount (#31772)
fda5073
@mw-ding
[Code] Remove socket.io and use polling message to pull progresses (#…
a4cc1d1 
…31398)

* [Code] Remove socket.io and use polling message to pull progresses

* [Code] refactor the status polling logic

* [Code] fix a minor test issue
@zfy0701
Merge remote-tracking branch 'origin/master' into feature/merge-code
6de9fa0
@spacedragon
[Code] correctly handle url when workspace is a symbol link. (#31782)
ff70ee0
@WangQianliang
fix(code/frontend): lose symbols (#31664)
9519432
@mw-ding
[Code] functional test for code intelligence (#31673)
821e47b
@spacedragon
[Code] Add api test for multi code node setup (#31460)
57fad3d
@mw-ding
[Code] fix the bug the first type in querybar is alwasy discarded (#3…
f493e54 
…1884)
@mw-ding
[Code] disable cross repo jump functional test
fbff7de
@WangQianliang
fix(code/frontend): replace deprecated react lifecycle methods (#31874)
46b9627
@mw-ding
[Code] Add duration for queued tasks (#31885)
22d64d9
@spacedragon @mw-ding
[Code] fix editor lifecycle method (#31983)
126eac4
@mw-ding @zfy0701
[Code] force delete repository (#31995)
dcd9282
@WangQianliang @zfy0701
feature(code/frontend): implement new breadcrumb design (#31247)
f48d420
@WangQianliang @zfy0701
[Code] handle import error (#31875)
0b7c437 
* fix(code/frontend): show import project error message
@mw-ding @zfy0701
[Code] increase the git clone/update throttle param to make ES data u…
630dfb6 
…pdate less frequent (#31988)
@WangQianliang @zfy0701
fix(code/frontend): side navigation bar width should be fixed (#31876)
d81f066
@WangQianliang @zfy0701
fix(code/frontend): should show import modal (#31987)
a136341
@spacedragon
[Code] update repo by set target ref directly (#32002)
bf29eef
@spacedragon @zfy0701
[Code] show nothing if setup status is not ready yet. (#31993)
ef185b1
@elasticmachine
Copy link
Contributor

elasticmachine commented Apr 22, 2019

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

elasticmachine commented Apr 22, 2019

💚 Build Succeeded

@spalger
Copy link
Contributor

spalger commented Apr 22, 2019

retest

spalger
spalger approved these changes Apr 22, 2019
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things are working great, light review of the code looks good, tests are passing regularly (I'll be keeping a close eye out for failures after merge) LGTM

@elasticmachine
Copy link
Contributor

elasticmachine commented Apr 22, 2019

💚 Build Succeeded

@zfy0701 zfy0701 requested review from mw-ding and removed request for mw-ding April 22, 2019 23:36
@elasticmachine
Copy link
Contributor

elasticmachine commented Apr 23, 2019

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

elasticmachine commented Apr 23, 2019

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

elasticmachine commented Apr 23, 2019

💚 Build Succeeded

@spalger
Copy link
Contributor

spalger commented Apr 23, 2019

So much green!

@elasticmachine
Copy link
Contributor

elasticmachine commented Apr 23, 2019

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

elasticmachine commented Apr 23, 2019

💚 Build Succeeded

@zfy0701 zfy0701 force-pushed the feature/merge-code branch from 22456a2 to b486992 Compare April 23, 2019 17:10
@elasticmachine
Copy link
Contributor

elasticmachine commented Apr 23, 2019

💔 Build Failed

@elasticmachine
Copy link
Contributor

elasticmachine commented Apr 23, 2019

💚 Build Succeeded

@zfy0701 zfy0701 merged commit b486992 into master Apr 23, 2019
@spalger spalger deleted the feature/merge-code branch May 30, 2019 06:27
@spalger spalger restored the feature/merge-code branch May 30, 2019 06:27
@spalger spalger deleted the feature/merge-code branch May 30, 2019 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kobelb kobelb kobelb approved these changes

@epixa epixa Awaiting requested review from epixa

+3 more reviewers

@mw-ding mw-ding mw-ding left review comments

@snide snide snide approved these changes

@spalger spalger spalger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@zfy0701 @elasticmachine @snide @spalger @kobelb @mw-ding @WangQianliang @spacedragon @daveyholler