Skip to content

[Code] commit hash font #33307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2019
Merged

[Code] commit hash font #33307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 4 additions & 13 deletions x-pack/plugins/code/public/components/main/commit_history.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,15 +34,6 @@ const Header = styled.div`
justify-content: space-between;
`;

const CommitId = styled.div`
height: calc(20rem / 14);
margin: auto 0;
text-align: center;
flex-shrink: 0;
`;

const CommitContainer = styled.div``;

const Commit = (props: { commit: CommitInfo; date: string; repoUri: string }) => {
const { date, commit } = props;
const { message, committer, id } = commit;
Expand All @@ -52,7 +43,7 @@ const Commit = (props: { commit: CommitInfo; date: string; repoUri: string }) =>
.join('');
return (
<EuiPanel className="code-timeline__commit--root">
<CommitContainer>
<div>
<EuiText size="s">
<p>{message}</p>
</EuiText>
Expand All @@ -61,10 +52,10 @@ const Commit = (props: { commit: CommitInfo; date: string; repoUri: string }) =>
{committer} · {date}
</EuiTextColor>
</EuiText>
</CommitContainer>
<CommitId>
</div>
<div className="code-commit-id">
<CommitLink repoUri={props.repoUri} commit={commitId} />
</CommitId>
</div>
</EuiPanel>
);
};
Expand Down
8 changes: 8 additions & 0 deletions x-pack/plugins/code/public/components/main/main.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,3 +271,11 @@
.code-no-min-width {
min-width: unset !important;
}

.code-commit-id {
@include euiCodeFont;
Copy link
Contributor

@mw-ding mw-ding Mar 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daveyholler is this what you mean? please take a second look

Copy link
Contributor

@daveyholler daveyholler Mar 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect.

height: calc(20rem / 14);
margin: auto 0;
text-align: center;
flex-shrink: 0;
}