Switch all TSVB comboboxes to plain text single selection #31879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
💔 Build Failed |
Contributor
Author
|
Jenkins, test this. Failure looks unreleated |
Contributor
💔 Build Failed |
flash1293
force-pushed
the
31585/fix-tsvb-keyboard-navigation
branch
from
c64a252 to
0f4920d
Compare
Contributor
💚 Build Succeeded |
cchaos
approved these changes
Feb 25, 2019
Contributor
cchaos
left a comment
cchaos
left a comment
There was a problem hiding this comment.
Did a quick scan of the replacements and it does properly only change singleSelection={true} to the plain text version.
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Feb 26, 2019
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Feb 26, 2019
flash1293
added a commit
that referenced
this pull request
Feb 26, 2019
flash1293
added a commit
that referenced
this pull request
Feb 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR switches all combo boxes with single selection to the plain text representation which helps a bit with the misconception of being able to add multiple values to a field. (related issue: #31585).
Before
After
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [] This includes a feature addition or change that requires a release note and was labeled appropriately