Introduce workaround for vega height bug #31461
Conversation
💔 Build Failed |
flash1293
force-pushed
the
25855/fix-vega-height-bug
branch
from
cdfcf71 to
daf4590
Compare
💚 Build Succeeded |
flash1293
changed the title
flash1293
added
the
Team:Visualizations
|
Pinging @elastic/kibana-app |
nyurik
left a comment
nyurik
left a comment
There was a problem hiding this comment.
I'm ok with this change, but is there a way to unit test this behavior? It would make it easier to remove this hack at a later date.
flash1293
force-pushed
the
25855/fix-vega-height-bug
branch
from
b6bad88 to
94efec0
Compare
|
@nyurik Done! It seems like this bug is triggered by very specific circumstances. For instance it didn't trigger if the font-size in the sample spec is smaller than 14px (maybe has sth. to do with the total height? No idea...) |
💚 Build Succeeded |
timroes
left a comment
timroes
left a comment
There was a problem hiding this comment.
Tested that it fixes the behavior. While testing figured out, that vega is really buggy with handling those signals in general. Hopefully something that will be fixed in future versions.
@timroes anything specific that Vega team can act on? They have been making amazing progress in code quality improvements - merged it into a monorepo, began using async/await, etc. It would be great if we can help them in this "never ending quest for quality and performance" :) |
|
Waiting for #31693 before merging this |
|
Tested the backported fix on 7.0, works also in IE |
* Failing test: Jest Tests.src/plugins/vis_type_vega/public * remove workaround for vega height bug Related to #31461 Co-authored-by: Elastic Machine <[email protected]>
) * Failing test: Jest Tests.src/plugins/vis_type_vega/public * remove workaround for vega height bug Related to elastic#31461 Co-authored-by: Elastic Machine <[email protected]>
…73015) * Failing test: Jest Tests.src/plugins/vis_type_vega/public * remove workaround for vega height bug Related to #31461 Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
4 participants
Summary
Fixes #25855
This is a workaround which hopefully becomes obsolete with vega 5 (currently upgrading doesn't work because of #31413
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately