Convert account screen to React/EUI#30977
Merged
legrego merged 27 commits intoelastic:masterfrom Apr 15, 2019
Merged
Conversation
legrego
added
WIP
Contributor
|
Pinging @elastic/kibana-security |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
legrego
changed the title
Contributor
|
retest |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
💔 Build Failed |
Member
Author
|
this is what I get for pushing updates without testing 😐 |
Contributor
💚 Build Succeeded |
kobelb
reviewed
Apr 15, 2019
Contributor
kobelb
left a comment
kobelb
left a comment
There was a problem hiding this comment.
nit: When changing your own password, if you enter an incorrect password the validation error is initially displayed correctly, but if you click "Change password" again, it clears the validation error:
| } | ||
|
|
||
| public static async getUser(username: string): Promise<User> { | ||
| const url = `${usersUrl}/${username}`; |
Contributor
There was a problem hiding this comment.
We weren't doing so previously, and the validation on the forms themselves is likely mitigating against this, but can we use encodeURIComponent here, and else-where in this file, when building URLs just to be safe?
Member
Author
Good catch, fixed in 08b0ac5. Thanks! |
Contributor
💚 Build Succeeded |
kobelb
approved these changes
Apr 15, 2019
legrego
added a commit
to legrego/kibana
that referenced
this pull request
Apr 15, 2019
* WIP account management redesign * style updates * start implementing change password logic * restyle * remove api key management section * improved change password validation * first round of design edits * cleanup and testing * fix import * fix translations * fix error handling on user management page * consolidate password change logic * fix tests * happy linter, happy life * finish change password test * removes unused translations * fix typo in test * fix change password functional test * Design edits (#19) - Made `fullWidth` - Added a consistent password requirement help text - Use `title` for toast - Change username/email to us `dl` - Don’t use html elements in tests * clear password form on success * copy edits * fix handling of Change Password button * use encodeURIComponent for user supplied data
Contributor
|
Reverted in a70a2cd |
Member
Author
|
Resubmitted in #35151 |
legrego
added a commit
that referenced
this pull request
Apr 16, 2019
## Summary This is a resubmission of #30977, which was reverted due to a functional test failure after merging. "Release note: Refreshed the look-and-feel of the account management screen."
legrego
added a commit
to legrego/kibana
that referenced
this pull request
Apr 16, 2019
## Summary This is a resubmission of elastic#30977, which was reverted due to a functional test failure after merging. "Release note: Refreshed the look-and-feel of the account management screen."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This converts the account management screen to React/EUI.
Closes #30844
Account with no Full Name or email address
Account with Full Name and email address
Account with password change disabled (e.g., SAML):
i18n test:
TODO
"Release note: Refreshed the look-and-feel of the account management screen."