[Maps] remove toasts for layer add and layer load error#30584
Merged
nreese merged 4 commits intoelastic:masterfrom Feb 12, 2019
Merged
[Maps] remove toasts for layer add and layer load error#30584nreese merged 4 commits intoelastic:masterfrom
nreese merged 4 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-gis |
Contributor
|
Can you find one more line to delete |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
thomasneirynck
approved these changes
Feb 11, 2019
Contributor
thomasneirynck
left a comment
thomasneirynck
left a comment
There was a problem hiding this comment.
this is a nice PR.
Together with https://github.com/elastic/kibana/pull/30542/files, layer-addition is really getting tidied up nicely
| return state; | ||
| } | ||
|
|
||
| return { |
Contributor
There was a problem hiding this comment.
shudders that reducer-code ...
kindsun
reviewed
Feb 11, 2019
| }, | ||
| ...layerList.slice(layerIdx + 1) | ||
| ] | ||
| }; |
Contributor
There was a problem hiding this comment.
I'm wondering if it's time we revisit the updateLayerInList function and update it to accept multiple attributes so we don't have to repeat this chunk of logic in the reducer
kindsun
approved these changes
Feb 11, 2019
Contributor
kindsun
left a comment
kindsun
left a comment
There was a problem hiding this comment.
Some minor feedback. Overall, a nice cleanup. lgtm!
cchaos
approved these changes
Feb 11, 2019
Contributor
cchaos
left a comment
cchaos
left a comment
There was a problem hiding this comment.
Just reviewed the SASS edits, and removals will always LGTM
This was referenced Feb 12, 2019
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Feb 12, 2019
* [Maps] remove toasts for layer add and layer load error * remove side-effects of LAYER_DATA_LOAD_ERROR action * more cleanup
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Feb 12, 2019
* [Maps] remove toasts for layer add and layer load error * remove side-effects of LAYER_DATA_LOAD_ERROR action * more cleanup
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Feb 13, 2019
* [Maps] remove toasts for layer add and layer load error * remove side-effects of LAYER_DATA_LOAD_ERROR action * more cleanup
nreese
added
the
release_note:skip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #30550 and #28022
The layer TOC provides feed back when there are errors loading layers so toasts are not needed. Same with adding a layer. This PR removes the
Toastscomponent.