[ML] Fixing position of job management search bar error #30251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgowdyelastic
added
review
v7.0.0
:ml
Feature:Anomaly Detection
jgowdyelastic
requested review from
alvarezmelissa87,
peteharverson and
walterra
Contributor
|
Pinging @elastic/ml-ui |
jgowdyelastic
changed the title
Contributor
💚 Build Succeeded |
snide
approved these changes
Feb 6, 2019
jgowdyelastic
force-pushed
the
k7-job-list-style-tweaks
branch
from
450bab1 to
255b887
Compare
peteharverson
approved these changes
Feb 7, 2019
Contributor
peteharverson
left a comment
peteharverson
left a comment
There was a problem hiding this comment.
Latest change LGTM
Contributor
💚 Build Succeeded |
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Feb 7, 2019
* [ML] Style tweaks for job management in K7 * adjusting search bar error * removing custom title style for EuiTitle
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Feb 7, 2019
* [ML] Style tweaks for job management in K7 * adjusting search bar error * removing custom title style for EuiTitle
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Feb 7, 2019
* [ML] Style tweaks for job management in K7 * adjusting search bar error * removing custom title style for EuiTitle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When entering invalid text into the search bar, then error is displayed in a callout which throws off the layout of the page, especially if the multi-select menu is visible.
This changes the error to be a normal eui form validation error.
Before:
After:
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers