[ML] Fixing the hiding of the timepicker on the settings and data visualizer landing page #30200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgowdyelastic
added
bug
jgowdyelastic
requested review from
alvarezmelissa87,
peteharverson and
walterra
Contributor
|
Pinging @elastic/ml-ui |
jgowdyelastic
force-pushed
the
fixing-hiding-of-timepicker-on-settings-page
branch
from
91d6074 to
dcbd24d
Compare
Contributor
💚 Build Succeeded |
jgowdyelastic
changed the title
Contributor
|
Latest changes LGTM 👍 |
Contributor
💚 Build Succeeded |
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Feb 6, 2019
…ualizer landing page (elastic#30200) * [ML] Fixing the hiding of the timepicker on the settings page * disabling timefilter on file data visualizer pages * removing comment
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Feb 6, 2019
…ualizer landing page (elastic#30200) * [ML] Fixing the hiding of the timepicker on the settings page * disabling timefilter on file data visualizer pages * removing comment
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Feb 6, 2019
…ualizer landing page (elastic#30200) * [ML] Fixing the hiding of the timepicker on the settings page * disabling timefilter on file data visualizer pages * removing comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The calls to disable the timepicker on the settings page were not inside the directive's
linkfunction and so were only ever being called once and not every time the user navigated to the page.