Skip to content

[Infra UI] Adapt settings ui to saved object version type change #30082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 5, 2019
Merged

[Infra UI] Adapt settings ui to saved object version type change #30082

merged 1 commit into from
Feb 5, 2019

Conversation

@weltenwort
Copy link
Member

@weltenwort weltenwort commented Feb 5, 2019

This fixes the version-based existence check which broke after the saved object version was changed from an integer to a string. The related change in Kibana only exists from 7.0 on.

@weltenwort weltenwort added v7.0.0 [zube]: In Progress Feature:Metrics UI Metrics UI feature Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Feb 5, 2019
@weltenwort weltenwort self-assigned this Feb 5, 2019
@elasticmachine
Copy link
Contributor

elasticmachine commented Feb 5, 2019

Pinging @elastic/infrastructure-ui

@weltenwort weltenwort force-pushed the infra-ui-fix-source-configuration-existence-check branch from 4a25cca to 98a5ab2 Compare February 5, 2019 15:12
@elasticmachine
Copy link
Contributor

elasticmachine commented Feb 5, 2019

💔 Build Failed

@weltenwort
Copy link
Member Author

weltenwort commented Feb 5, 2019

looks flakey - jenkins, test this again

@elasticmachine
Copy link
Contributor

elasticmachine commented Feb 5, 2019

💚 Build Succeeded

skh
skh approved these changes Feb 5, 2019
View reviewed changes
Copy link
Contributor

@skh skh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@weltenwort weltenwort merged commit fd061ab into elastic:master Feb 5, 2019
weltenwort added a commit to weltenwort/kibana that referenced this pull request Mar 11, 2019
@weltenwort
[Infra UI] Adapt settings ui to saved object version type change (ela…
edeb1db 
…stic#30082)
@weltenwort weltenwort mentioned this pull request Mar 11, 2019
Merged
weltenwort added a commit that referenced this pull request Mar 11, 2019
@weltenwort
[Infra UI] Adapt settings ui to saved object version type change (#30082
6c82b88 
) (#32938)

Backports the following commits to 6.7:
 - [Infra UI] Adapt settings ui to saved object version type change (#30082) (#29622)

Caused by backport of #29906 to `6.x`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simianhacker simianhacker Awaiting requested review from simianhacker

@Kerry350 Kerry350 Awaiting requested review from Kerry350

1 more reviewer

@skh skh skh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@weltenwort weltenwort

Labels

Feature:Logs UI Logs UI feature Feature:Metrics UI Metrics UI feature review Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@weltenwort @elasticmachine @skh @ruflin