[OSS-Telemetry] Make the plugin have the right config prefix #30005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
added
review
v7.0.0
Team:Visualizations
Contributor
|
Pinging @elastic/kibana-app |
Contributor
💚 Build Succeeded |
Member
Author
|
6.x/6.7: #30132 |
tsullivan
added a commit
that referenced
this pull request
Feb 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#28793 added a new
oss_telemetryplugin in x-pack. I realized after the fact the config prefix for the plugin should bexpack.oss_telemetryinstead of just the default.The way to disable the plugin:
Before
After