[Maps] Apply tile styles before waiting for _tileLoadErrorTracker timer to expire#29798
Merged
nreese merged 2 commits intoelastic:masterfrom Feb 1, 2019
Merged
[Maps] Apply tile styles before waiting for _tileLoadErrorTracker timer to expire#29798nreese merged 2 commits intoelastic:masterfrom
nreese merged 2 commits intoelastic:masterfrom
Conversation
nreese
added
v7.0.0
Team:Geo
Contributor
|
Pinging @elastic/kibana-gis |
Contributor
💚 Build Succeeded |
thomasneirynck
approved these changes
Feb 1, 2019
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Feb 1, 2019
…er to expire (elastic#29798) * [Maps] avoid re-loading tiles after * set starting min and max to values provided from descriptor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#28852 introduced a bug causing all tiles to be re-fetched. There are 2 ways to view the bug
TileLayer._tileLoadErrorTrackertimer to expire). Notice how all the tiles flicker because they are being re-fetchedgetLayerListto return a different array soTileLayer.syncLayerWithMBis triggered. An easy one is changing the time range. Notice how all the tiles flicker because there are being re-fetched.The bug occurs because for some unknown reason, calling
mbMap.setLayerZoomRangewith new min/max causes mapbox-gl to re-request all tiles (I opened an issue to figure out why mapbox/mapbox-gl-js#7865). In our case, we should not wait until afterthis._tileLoadErrorTrackerhas fired to set the layer properties.