Skip to content

[i18n] Move welcome error message from a script insertion to a data attribute#29581

Merged
maryia-lapata merged 1 commit intoelastic:masterfrom
maryia-lapata:i18n/fix-broken-quote
Jan 30, 2019
Merged

[i18n] Move welcome error message from a script insertion to a data attribute#29581
maryia-lapata merged 1 commit intoelastic:masterfrom
maryia-lapata:i18n/fix-broken-quote

Conversation

@maryia-lapata
Copy link
Contributor

@maryia-lapata maryia-lapata commented Jan 30, 2019

Fix issue with a single quote in French

This PR is based on #10581 and fixes #10580

Checked with French locale

fr_error

image

and with Chinese locale

zn_error

zn_div

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@azasypkin azasypkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@azasypkin azasypkin changed the title [i18n] Move welcome error message from a script insertion to a hidden <div> [i18n] Move welcome error message from a script insertion to a data attribute Jan 30, 2019
Copy link
Contributor

@pavel06081991 pavel06081991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maryia-lapata
Copy link
Contributor Author

6.x/6.7.0: 1a305be

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

single quote ' in translation string breaks ui_app.jade

4 participants