Skip to content

Conversation

@nreese
Copy link
Contributor

@nreese nreese commented Jan 29, 2019

Upgrade to eui 6.7.4

Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending green ci.

@elasticmachine
Copy link
Contributor

💔 Build Failed

@snide
Copy link
Contributor

snide commented Jan 30, 2019

retest

@elasticmachine
Copy link
Contributor

💔 Build Failed

@nreese
Copy link
Contributor Author

nreese commented Jan 30, 2019

jenkins, test this

@elasticmachine
Copy link
Contributor

💔 Build Failed

@nreese nreese requested a review from a team as a code owner January 30, 2019 15:42
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

overflow: hidden;
}

@include euiBreakpoint('xs') {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed because EUI no longer has a mobile header height difference
elastic/eui#1480

@elasticmachine
Copy link
Contributor

💔 Build Failed

@nreese
Copy link
Contributor Author

nreese commented Jan 30, 2019

flaky test in kibana OSS CI group 2

fail: "dashboard app using current data dashboard embeddable rendering data rendered correctly when dashboard is opened from listing page

jenkins, test this

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@nreese nreese merged commit 6e6be37 into elastic:master Jan 30, 2019
nreese added a commit to nreese/kibana that referenced this pull request Jan 30, 2019
* update to eui 6.7.4

* remove use of euiHeaderChildSizeMobile for xs header check
@elasticmachine
Copy link
Contributor

💔 Build Failed

nreese added a commit that referenced this pull request Jan 30, 2019
* update to eui 6.7.4

* remove use of euiHeaderChildSizeMobile for xs header check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants