[6.x] [Maps] Handle unavailable tilemap services (#28852)#29542
Merged
kindsun merged 1 commit intoelastic:6.xfrom Jan 29, 2019
Merged
[6.x] [Maps] Handle unavailable tilemap services (#28852)#29542kindsun merged 1 commit intoelastic:6.xfrom
kindsun merged 1 commit intoelastic:6.xfrom
Conversation
* Update ems utils to better handle no service results. Prevent excess attribution errors * Update tile layer sync to return promise and handle errors related to both obtaining url and tile loading * Add flow for updating tms layers with error status/message * Handle promises, if returned, on syncLayerWithMB. Update TMS error status * Exclude layers that mapbox didn't add to map but are tracked in layer list from reordering logic * Move datarequest handling to vector layer. Use relevant data load/error logic for tile and vector layers * Don't try to get attributions on errored layer * Handle 'includeElasticMapsService' configuration * Move data requests back to layer level for heatmap usage * Update all layers to set top-level layer error status and message. Consolidate redundant code * Update tile sync function to more reliably confirm load status after loading via callback. Add interval to cancel timer * Remove unnecessary, and annoying, clear temp layers on tms error * Clean up * More clean up * Review feedback * Review feedback. Test cleanup * Test fixes and review feedback
Contributor
💚 Build Succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 6.x: