fix: wrap url check in retry.try #29536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w33ble
added
review
v7.0.0
Team:Presentation
Contributor
|
Pinging @elastic/kibana-canvas |
Contributor
💔 Build Failed |
Contributor
|
Please make sure to pull master regularly, this PR is based on 1ba6c28 which is about 5 days old. Pulling master will fix the CI failure. |
since the url changes are async, keep testing the url until it passes or fails enough times
w33ble
force-pushed
the
fix/flakey-url-smoke-test
branch
from
96ca619 to
7c9a245
Compare
Contributor
💚 Build Succeeded |
LeeDr
approved these changes
Jan 30, 2019
LeeDr
left a comment
LeeDr
left a comment
There was a problem hiding this comment.
LGTM - I did not test it locally but it passed on Jenkins and this is the type of fix we do for these cases.
w33ble
added a commit
to w33ble/kibana
that referenced
this pull request
Jan 30, 2019
since the url changes are async, keep testing the url until it passes or fails enough times
w33ble
added a commit
to w33ble/kibana
that referenced
this pull request
Jan 30, 2019
since the url changes are async, keep testing the url until it passes or fails enough times
w33ble
added a commit
that referenced
this pull request
Jan 30, 2019
w33ble
added a commit
that referenced
this pull request
Jan 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #26441
Since the url changes are async, keep testing the url until it passes or fails enough times.