Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove es _xpack endpoint usage #29465

Merged
merged 16 commits into from
Jan 29, 2019
Merged

Remove es _xpack endpoint usage #29465

merged 16 commits into from
Jan 29, 2019

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented Jan 28, 2019

With elastic/elasticsearch#35958 most endpoints starting with _xpack are deprecated. This replaces _xpack endpoints to start with their respective plugin name.

Closes #29447

@jbudz jbudz added WIP Work in progress v7.0.0 labels Jan 28, 2019
@jbudz jbudz self-assigned this Jan 28, 2019
@jbudz jbudz requested a review from a team as a code owner January 28, 2019 19:20
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@jbudz
Copy link
Member Author

jbudz commented Jan 28, 2019 •
edited
Loading

LF reviews :), if anyone wants changes in a separate PR let me know.

@jbudz jbudz added review and removed WIP Work in progress labels Jan 28, 2019
@chrisronline
Copy link
Contributor

@jbudz Is there anything we should be watching out for with this? The changes look straight forward, but I don't know if there any known edge cases we should worry about?

@jbudz
Copy link
Member Author

jbudz commented Jan 28, 2019

You got it, mostly a find and replace from _xpack/plugin to _plugin. The only different one was the underscore prefix in _bulk is removed. so _xpack/monitoring/_bulk to _monitoring/bulk.

chrisronline
chrisronline approved these changes Jan 28, 2019
View reviewed changes
Copy link
Contributor

@chrisronline chrisronline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for stack-monitoring!

kobelb
kobelb approved these changes Jan 28, 2019
View reviewed changes
Copy link
Contributor

@kobelb kobelb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for catching that stray security API, I thought I got them all before.

cjcenizal
cjcenizal approved these changes Jan 28, 2019
View reviewed changes
Copy link
Contributor

@cjcenizal cjcenizal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elastic/es-ui LGTM, though it wouldn't hurt to have @bmcconaghy take a gander at the console stuff.

That said, do we expect to have all mention of X-Pack removed from Console? Looks like it still pops up:

image

@w33ble w33ble self-requested a review January 28, 2019 23:20
@jbudz
Copy link
Member Author

jbudz commented Jan 29, 2019

👍 a couple endpoints are sticking around, those included for general information. With that said I'm going to back out the console changes in favor of #29506

@chrisronline chrisronline mentioned this pull request Jan 29, 2019
Closed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

w33ble
w33ble approved these changes Jan 29, 2019
View reviewed changes
Copy link
Contributor

@w33ble w33ble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Canvas is still functioning correctly with the updated sql endpoint.

@jbudz jbudz merged commit e9f0006 into elastic:master Jan 29, 2019
@jbudz jbudz mentioned this pull request Jan 29, 2019
Closed
@chrisronline chrisronline mentioned this pull request Feb 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcenizal cjcenizal cjcenizal approved these changes

@kobelb kobelb kobelb approved these changes

@w33ble w33ble w33ble approved these changes

@chrisronline chrisronline chrisronline approved these changes

Assignees

@jbudz jbudz

Labels
review v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jbudz @elasticmachine @chrisronline @w33ble @kobelb @cjcenizal