Fix bug in xpackInfo in which keys were being camel-cased during refresh but not init

[cjcenizal]

This fixes a bug in a CCR feature we're working on, but introduces an error in Beats Management:

This error comes from this line: https://github.com/elastic/kibana/blob/master/x-pack/plugins/beats_management/public/lib/adapters/framework/kibana_framework_adapter.ts#L114

It stems from the fact that Beats Management attempts to retrieve xpackInfo using its plugin ID, beats_management.

I can think of a couple solutions:

1. Beats management changes its implementation to use a camel-cased ID to retrieve its xpack info.
2. We change xpackInfo's implementation to not camel-case the keys its using. I'm somewhat leaning towards this solution since it seems like surprising behavior for it to alter the data its receiving. But I'd like to get Shaunak's perspective first to make sure we don't lose anything by doing so.

[cjcenizal]

Tagging Shaunak for review because he originally introduced the camel-casing logic in X-Pack.

[elasticmachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request

[ycombinator]

I don't know the full context of this PR but I can certainly try to explain a bit of history on where the camel-casing logic came from, if that might help:

At the time the xpackInfo functionality was developed (circa June 2016 IIRC), Kibana had a convention of using snake_case in API response bodies. And it also had the convention of using camelCase in JS object structures. The xpackInfo data structure lives as a JS object on the server-side, is serialized to JSON and transported to the client-side via an HTTP API. Hence the logic of changing the case back and forth.

Hope that helps!

[mattapperson]

Seems to me we often still try to keep this convention. So for that reason I would lean to BeatsCM changing. Just curious if that’s a convention we WANT to keep, or one we have kept just because.

[cjcenizal]

@mattapperson Sounds good, I agree. Would you mind submitting a PR into this one to update Beats?

[cjcenizal]

CI should go green once Beats is updated.

[elasticmachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request

[bmcconaghy]

Code LGTM

[cjcenizal]

Retest

[elasticmachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request

[cjcenizal]

CI went green and I only pushed a code comment, so I'm going to merge without waiting for CI to pass again.

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request