[i18n] Translate kuery_autocomplete #29162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
second merge
Contributor
💚 Build Succeeded |
Nox911
requested review from
pavel06081991
and removed request for
maryia-lapata
pavel06081991
approved these changes
Jan 24, 2019
Contributor
pavel06081991
left a comment
pavel06081991
left a comment
There was a problem hiding this comment.
LGTM. Tested locally, works good.
timroes
suggested changes
Jan 25, 2019
x-pack/plugins/kuery_autocomplete/public/autocomplete_providers/conjunction.js
Outdated
Show resolved
Hide resolved
x-pack/plugins/kuery_autocomplete/public/autocomplete_providers/conjunction.js
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Fixed description and replaced concat to backticks in values(Aleh Zasypkin asked me to do it). |
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
Nox911
added a commit
to Nox911/kibana
that referenced
this pull request
Jan 29, 2019
* Translate kuery_autocomplete * Resolve review comments
Nox911
added a commit
that referenced
this pull request
Jan 29, 2019
Contributor
Author
|
6.x/6.7.0: 73567a2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Translate x-pack -> plugins -> kuery_autocomplete
Guidline
Readme