[migrations] fetch mappings with types #28497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 10, 2019 08:41
…7 (master) (elastic#28369)" This reverts commit 2b593f1.
Contributor
|
Pinging @elastic/kibana-operations |
spalger
changed the title
joshdover
approved these changes
Jan 10, 2019
chrisdavies
approved these changes
Jan 10, 2019
Contributor
chrisdavies
left a comment
chrisdavies
left a comment
There was a problem hiding this comment.
LGTM, but the async function is not async, so I'd remove that.
This comment has been minimized.
This comment has been minimized.
Contributor
💚 Build Succeeded |
tylersmalley
pushed a commit
to tylersmalley/kibana
that referenced
this pull request
Jan 15, 2019
Follow-up to elastic#28497 Since elastic/elasticsearch#37285 has been merged, it's aparent there are a couple more places we need to specify include_type_name as a stop-gap until elastic#23650 is completed Signed-off-by: Tyler Smalley <[email protected]>
chrisdavies
pushed a commit
that referenced
this pull request
Jan 15, 2019
* [migrations] Fetch additional mappings with types Follow-up to #28497 Since elastic/elasticsearch#37285 has been merged, it's aparent there are a couple more places we need to specify include_type_name as a stop-gap until #23650 is completed Signed-off-by: Tyler Smalley <[email protected]> * Updates tests Signed-off-by: Tyler Smalley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #28369 and instead applies a suggestion from @joshdover to request the mappings with the type names included. This causes ES master to respond in the same format as it did a couple days ago so that we can unblock development while @chrisdavies works on longer-term fixes for ES v7 compatibility.